From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC Patch v5] Consolidate bool type
Date: Thu, 24 Jan 2013 11:13:27 -0800 [thread overview]
Message-ID: <510187D7.20601@freescale.com> (raw)
In-Reply-To: <1359054567.24865.13@snotra>
On 01/24/2013 11:09 AM, Scott Wood wrote:
> On 01/24/2013 12:47:10 PM, York Sun wrote:
>> diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py
>> index d831087..28b3240 100644
>> --- a/tools/patman/checkpatch.py
>> +++ b/tools/patman/checkpatch.py
>> @@ -48,12 +48,12 @@ def FindCheckPatch():
>> print 'Could not find checkpatch.pl'
>> return None
>>
>> -def CheckPatch(fname, verbose=False):
>> +def CheckPatch(fname, verbose=false):
>> """Run checkpatch.pl on a file.
>>
>> Returns:
>> 4-tuple containing:
>> - result: False=failure, True=ok
>> + result: false=failure, true=ok
>> problems: List of problems, each a dict:
>> 'type'; error or warning
>> 'msg': text message
>
> You should probably limit the change to C code. :-)
>
Nice catch. I forgot Python use True and False. Will fix.
York
next prev parent reply other threads:[~2013-01-24 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 18:47 [U-Boot] [RFC Patch v5] Consolidate bool type York Sun
2013-01-24 19:09 ` Scott Wood
2013-01-24 19:13 ` York Sun [this message]
2013-01-24 19:29 ` Allen Martin
2013-01-24 19:39 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510187D7.20601@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.