From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajeev kumar Subject: Re: [patch] ASoC: dwc: fix support for more than two channels Date: Fri, 25 Jan 2013 14:03:46 +0530 Message-ID: <5102436A.4030205@st.com> References: <20130125064343.GE4882@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from eu1sys200aog104.obsmtp.com (eu1sys200aog104.obsmtp.com [207.126.144.117]) by alsa0.perex.cz (Postfix) with ESMTP id D9444261718 for ; Fri, 25 Jan 2013 09:33:55 +0100 (CET) In-Reply-To: <20130125064343.GE4882@elgon.mountain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Dan Carpenter Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Mark Brown , "kernel-janitors@vger.kernel.org" , Liam Girdwood List-Id: alsa-devel@alsa-project.org T24gMS8yNS8yMDEzIDEyOjEzIFBNLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IGhlcmUgd2VyZSBt aXNzaW5nIGJyZWFrIHN0YXRlbWVudHMgc28gZXZlcnl0aGluZyB1c2VkCj4gVFdPX0NIQU5ORUxf U1VQUE9SVC4KPgo+IEFsc28gSSBhZGRlZCBhIHJldHVybiBzdGF0ZW1lbnQgdG8gc2lsZW5jZSBh IEdDQyB3YXJuaW5nOgo+Cj4gCXNvdW5kL3NvYy9kd2MvZGVzaWdud2FyZV9pMnMuYzogSW4gZnVu Y3Rpb24g4oCYZHdfaTJzX2h3X3BhcmFtc+KAmToKPiAJc291bmQvc29jL2R3Yy9kZXNpZ253YXJl X2kycy5jOjIzNjozMjogd2FybmluZzog4oCYY2hfcmVn4oCZIG1heSBiZQo+IAkJdXNlZCB1bmlu aXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24KPiAJCVstV21heWJlLXVuaW5pdGlhbGl6ZWRdCj4K PiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4K PiAtLS0KPiBTdGF0aWMgYW5hbHlzaXMuICBVbnRlc3RlZC4KCkFja2VkIEJ5OiBSYWplZXYgS3Vt YXIgPHJhamVldi1kbGgua3VtYXJAc3QuY29tPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFs c2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajeev kumar Date: Fri, 25 Jan 2013 08:45:46 +0000 Subject: Re: [patch] ASoC: dwc: fix support for more than two channels Message-Id: <5102436A.4030205@st.com> List-Id: References: <20130125064343.GE4882@elgon.mountain> In-Reply-To: <20130125064343.GE4882@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Mark Brown , "kernel-janitors@vger.kernel.org" , Liam Girdwood On 1/25/2013 12:13 PM, Dan Carpenter wrote: > here were missing break statements so everything used > TWO_CHANNEL_SUPPORT. > > Also I added a return statement to silence a GCC warning: > > sound/soc/dwc/designware_i2s.c: In function ‘dw_i2s_hw_params’: > sound/soc/dwc/designware_i2s.c:236:32: warning: ‘ch_reg’ may be > used uninitialized in this function > [-Wmaybe-uninitialized] > > Signed-off-by: Dan Carpenter > --- > Static analysis. Untested. Acked By: Rajeev Kumar