All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Vishvananda Ishaya <vishvananda@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] block: Create proper size file for disk mirror
Date: Fri, 25 Jan 2013 10:18:26 +0100	[thread overview]
Message-ID: <51024DE2.907@redhat.com> (raw)
In-Reply-To: <1359050440-52511-1-git-send-email-vishvananda@gmail.com>

Am 24.01.2013 19:00, schrieb Vishvananda Ishaya:
> The qmp monitor command to mirror a disk was passing -1 for size
> along with the disk's backing file. This size of the resulting disk
> is the size of the backing file, which is incorrect if the disk
> has been resized. Therefore we should always pass in the size of
> the current disk.
> 
> Signed-off-by: Vishvananda Ishaya <vishvananda@gmail.com>

Thanks, applied to the block branch.

Can you send a qemu-iotests test case that tests this condition?
(Probably best as an extension to case 041)

Kevin


  reply	other threads:[~2013-01-25  9:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24 18:00 [Qemu-trivial] [PATCH] block: Create proper size file for disk mirror Vishvananda Ishaya
2013-01-25  9:18 ` Kevin Wolf [this message]
2013-01-25 18:10   ` Vishvananda Ishaya
2013-01-25 18:13     ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2013-01-25 18:28       ` Kevin Wolf
2013-01-25 18:57   ` [Qemu-trivial] [PATCH] block: Adds mirroring tests for resized images Vishvananda Ishaya
2013-01-25 22:42     ` Paolo Bonzini
2013-01-29 14:52     ` Stefan Hajnoczi
2013-01-25  9:31 ` [Qemu-trivial] [PATCH] block: Create proper size file for disk mirror Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51024DE2.907@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vishvananda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.