From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Wroblewski Subject: Re: [PATCH v2] Fix scheduler crash after s3 resume Date: Fri, 25 Jan 2013 11:18:55 +0100 Message-ID: <51025C0F.2020908@citrix.com> References: <5100070F.7010808@citrix.com> <5100D229.4030906@ts.fujitsu.com> <510144A3.9060302@citrix.com> <5101630D02000078000B93AD@nat28.tlf.novell.com> <51016065.3080902@citrix.com> <510175E802000078000B94A1@nat28.tlf.novell.com> <51024B56.20706@citrix.com> <5102603302000078000B985C@nat28.tlf.novell.com> <5102541D.1070408@citrix.com> <5102694B02000078000B98B7@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5102694B02000078000B98B7@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: George Dunlap , Juergen Gross , "Keir (Xen.org)" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org > But you neglect the fact that waking vCPU-s at this point is > unnecessary anyway (they have nowhere to run on). > > Hm, can't they still run on cpu 0? Also, I did earlier try to patch this more primitively by adding a check to vcpu_wake whether the cpu is in cpu_online_map, and whilst it stopped the crashing, I observed some unexpected hangs w/o any serial output - sometimes just the dom0 would hang, sometimes also xen would stop being responsive on serial. So I figured out that these missed vcpu wakes account for something still.