From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0
Date: Fri, 25 Jan 2013 16:20:13 +0530 [thread overview]
Message-ID: <51026365.1020402@ti.com> (raw)
In-Reply-To: <1359027324-14534-1-git-send-email-manishv.b@ti.com>
On 1/24/2013 5:05 PM, Vishwanathrao Badarkhe, Manish wrote:
> Add I2C0 device tree node information to da850-evm.
> Also, add I2C0 pin muxing information in da850-evm.
>
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> ---
> Depends on patch
> http://comments.gmane.org/gmane.linux.davinci/25993
>
> arch/arm/boot/dts/da850-evm.dts | 15 +++++++++++++++
> arch/arm/boot/dts/da850.dtsi | 10 ++++++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 8cac9d2..3d8290a 100755
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -27,5 +27,20 @@
> serial2: serial at 1d0d000 {
> status = "okay";
> };
> + i2c0 at 1c22000 {
This should be
i2c0: i2c at 1c22000
to follow the convention elsewhere in file.
> + status = "okay";
> + };
> + };
> +};
> +&pmx_core {
> + pinctrl-names = "default";
> + pinctrl-0 = <
> + &i2c0_pins
> + >;
> +
> + i2c0_pins: pinmux_i2c0_pins{
> + pinctrl-single,bits = <
> + 0x10 0x00002200 0x0000ff00 /* I2C0_SDA,I2C0_SCL */
> + >;
This should go into the dtsi file. See the discussion on NAND DT support
submitted by Anil Kumar.
Thanks,
Sekhar
PS: You are using an old address for Kevin Hilman. The MAINTAINERS file
has been updated for a long time now. Liam's address is also wrong but I
don't have his updated e-mail.
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
Cc: devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
davinci-linux-open-source@linux.davincidsp.com,
Kevin Hilman <khilman@deeprootsystems.com>,
linux@arm.linux.org.uk, sameo@linux.intel.com, tony@atomide.com,
broonie@opensource.wolfsonmicro.com, rob.herring@calxeda.com,
grant.likely@secretlab.ca, rob@landley.net, anilkumar@ti.com,
hs@denx.de
Subject: Re: [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0
Date: Fri, 25 Jan 2013 16:20:13 +0530 [thread overview]
Message-ID: <51026365.1020402@ti.com> (raw)
In-Reply-To: <1359027324-14534-1-git-send-email-manishv.b@ti.com>
On 1/24/2013 5:05 PM, Vishwanathrao Badarkhe, Manish wrote:
> Add I2C0 device tree node information to da850-evm.
> Also, add I2C0 pin muxing information in da850-evm.
>
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> ---
> Depends on patch
> http://comments.gmane.org/gmane.linux.davinci/25993
>
> arch/arm/boot/dts/da850-evm.dts | 15 +++++++++++++++
> arch/arm/boot/dts/da850.dtsi | 10 ++++++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 8cac9d2..3d8290a 100755
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -27,5 +27,20 @@
> serial2: serial@1d0d000 {
> status = "okay";
> };
> + i2c0@1c22000 {
This should be
i2c0: i2c@1c22000
to follow the convention elsewhere in file.
> + status = "okay";
> + };
> + };
> +};
> +&pmx_core {
> + pinctrl-names = "default";
> + pinctrl-0 = <
> + &i2c0_pins
> + >;
> +
> + i2c0_pins: pinmux_i2c0_pins{
> + pinctrl-single,bits = <
> + 0x10 0x00002200 0x0000ff00 /* I2C0_SDA,I2C0_SCL */
> + >;
This should go into the dtsi file. See the discussion on NAND DT support
submitted by Anil Kumar.
Thanks,
Sekhar
PS: You are using an old address for Kevin Hilman. The MAINTAINERS file
has been updated for a long time now. Liam's address is also wrong but I
don't have his updated e-mail.
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
Cc: <devicetree-discuss@lists.ozlabs.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<davinci-linux-open-source@linux.davincidsp.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
<linux@arm.linux.org.uk>, <sameo@linux.intel.com>,
<tony@atomide.com>, <broonie@opensource.wolfsonmicro.com>,
<rob.herring@calxeda.com>, <grant.likely@secretlab.ca>,
<rob@landley.net>, <anilkumar@ti.com>, <hs@denx.de>
Subject: Re: [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0
Date: Fri, 25 Jan 2013 16:20:13 +0530 [thread overview]
Message-ID: <51026365.1020402@ti.com> (raw)
In-Reply-To: <1359027324-14534-1-git-send-email-manishv.b@ti.com>
On 1/24/2013 5:05 PM, Vishwanathrao Badarkhe, Manish wrote:
> Add I2C0 device tree node information to da850-evm.
> Also, add I2C0 pin muxing information in da850-evm.
>
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> ---
> Depends on patch
> http://comments.gmane.org/gmane.linux.davinci/25993
>
> arch/arm/boot/dts/da850-evm.dts | 15 +++++++++++++++
> arch/arm/boot/dts/da850.dtsi | 10 ++++++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 8cac9d2..3d8290a 100755
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -27,5 +27,20 @@
> serial2: serial@1d0d000 {
> status = "okay";
> };
> + i2c0@1c22000 {
This should be
i2c0: i2c@1c22000
to follow the convention elsewhere in file.
> + status = "okay";
> + };
> + };
> +};
> +&pmx_core {
> + pinctrl-names = "default";
> + pinctrl-0 = <
> + &i2c0_pins
> + >;
> +
> + i2c0_pins: pinmux_i2c0_pins{
> + pinctrl-single,bits = <
> + 0x10 0x00002200 0x0000ff00 /* I2C0_SDA,I2C0_SCL */
> + >;
This should go into the dtsi file. See the discussion on NAND DT support
submitted by Anil Kumar.
Thanks,
Sekhar
PS: You are using an old address for Kevin Hilman. The MAINTAINERS file
has been updated for a long time now. Liam's address is also wrong but I
don't have his updated e-mail.
next prev parent reply other threads:[~2013-01-25 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 11:35 [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0 Vishwanathrao Badarkhe, Manish
2013-01-24 11:35 ` Vishwanathrao Badarkhe, Manish
2013-01-24 11:35 ` Vishwanathrao Badarkhe, Manish
2013-01-25 10:50 ` Sekhar Nori [this message]
2013-01-25 10:50 ` Sekhar Nori
2013-01-25 10:50 ` Sekhar Nori
2013-01-28 5:17 ` Vishwanathrao Badarkhe, Manish
2013-01-28 5:17 ` Vishwanathrao Badarkhe, Manish
2013-01-28 5:17 ` Vishwanathrao Badarkhe, Manish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51026365.1020402@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.