From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH 1/2] ARM: dts: omap3-overo: Add support for pwm-leds Date: Fri, 25 Jan 2013 13:07:06 +0100 Message-ID: <5102756A.9040901@ti.com> References: <1358963812-19947-1-git-send-email-florian.vaussard@epfl.ch> <1358963812-19947-2-git-send-email-florian.vaussard@epfl.ch> <5101510C.9050407@ti.com> <51015663.8080109@epfl.ch> <5101570A.1030303@ti.com> <5101663C.7020301@epfl.ch> <51016A84.20703@ti.com> <5101A43D.7080108@epfl.ch> <51024254.40208@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:36091 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756434Ab3AYMHZ (ORCPT ); Fri, 25 Jan 2013 07:07:25 -0500 In-Reply-To: <51024254.40208@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: florian.vaussard@epfl.ch Cc: Tony Lindgren , devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, Benoit Cousson , linux-arm-kernel@lists.infradead.org On 01/25/2013 09:29 AM, Peter Ujfalusi wrote: > On 01/24/2013 10:14 PM, Florian Vaussard wrote: >> You are right. But then the pwm core must provide a way to know if t= he pwm >> access function are callable >> from atomic context or not (the gpio framework provides gpio_canslee= p()). >> This implies a good amount of changes to the pwm framework, and curr= ently we >> are the only driver using non-atomic access. >=20 > We have two drivers at the moment: pwm-twl and pwm-twl-led. However n= ew out of > SoC PWM drivers might come (for example for palmas). So it worth take= a look > at some generic implementation. OK. So I have the series. I need to add few more things but pwm-leds on BeagleBoard works fine when I put the default_trigger for the pmustat L= ED to be mmc0. It is blinking happily ;) I'll CC you with the patches when I send them. --=20 P=E9ter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Fri, 25 Jan 2013 13:07:06 +0100 Subject: [PATCH 1/2] ARM: dts: omap3-overo: Add support for pwm-leds In-Reply-To: <51024254.40208@ti.com> References: <1358963812-19947-1-git-send-email-florian.vaussard@epfl.ch> <1358963812-19947-2-git-send-email-florian.vaussard@epfl.ch> <5101510C.9050407@ti.com> <51015663.8080109@epfl.ch> <5101570A.1030303@ti.com> <5101663C.7020301@epfl.ch> <51016A84.20703@ti.com> <5101A43D.7080108@epfl.ch> <51024254.40208@ti.com> Message-ID: <5102756A.9040901@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/25/2013 09:29 AM, Peter Ujfalusi wrote: > On 01/24/2013 10:14 PM, Florian Vaussard wrote: >> You are right. But then the pwm core must provide a way to know if the pwm >> access function are callable >> from atomic context or not (the gpio framework provides gpio_cansleep()). >> This implies a good amount of changes to the pwm framework, and currently we >> are the only driver using non-atomic access. > > We have two drivers at the moment: pwm-twl and pwm-twl-led. However new out of > SoC PWM drivers might come (for example for palmas). So it worth take a look > at some generic implementation. OK. So I have the series. I need to add few more things but pwm-leds on BeagleBoard works fine when I put the default_trigger for the pmustat LED to be mmc0. It is blinking happily ;) I'll CC you with the patches when I send them. -- P?ter