From: Eric Sandeen <sandeen@redhat.com>
To: Gene Czarcinski <gene@czarc.net>
Cc: linux-btrfs@vger.kernel.org, Stefan Behrens <sbehrens@giantdisaster.de>
Subject: Re: [PATCH] Btrfs-progs: remove btrfsctl, btrfs-show and btrfs-vol from default build
Date: Fri, 25 Jan 2013 09:32:01 -0600 [thread overview]
Message-ID: <5102A571.8030608@redhat.com> (raw)
In-Reply-To: <51027339.9030604@czarc.net>
On 1/25/13 5:57 AM, Gene Czarcinski wrote:
> On 06/08/2012 02:00 PM, Stefan Behrens wrote:
>> Remove btrfsctl, btrfs-show and btrfs-vol from "all" target of Makefile.
TBH, unless there are objections, I'd rather remove the source files as well.
Having unbuilt source code lying around is potentially even more confusing.
I'd at least move it to a deprecated/ subdir or something, but it'll only
fester and die there as well. I'd just remove it, if it's time to do so.
Are they fully deprecated? Is there anything these tools do that btrfs
does not?
-Eric
>> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
>> ---
>> Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index aaf1381..79e7a56 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -18,7 +18,7 @@ bindir = $(prefix)/bin
>> LIBS=-luuid
>> RESTORE_LIBS=-lz
>>
>> -progs = btrfsctl mkfs.btrfs btrfs-debug-tree btrfs-show btrfs-vol btrfsck \
>> +progs = mkfs.btrfs btrfs-debug-tree btrfsck \
>> btrfs btrfs-map-logical btrfs-image btrfs-zero-log btrfs-convert \
>> btrfs-find-root btrfs-restore btrfstune
>>
>>
> I agree. It is time to remove these old programs; they serve no useful purpose; and they complicate maintenance.
>
> Gene
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-25 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 18:00 [PATCH] Btrfs-progs: remove btrfsctl, btrfs-show and btrfs-vol from default build Stefan Behrens
2013-01-25 11:57 ` Gene Czarcinski
2013-01-25 15:32 ` Eric Sandeen [this message]
2013-01-25 15:49 ` Stefan Behrens
2013-01-28 3:03 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5102A571.8030608@redhat.com \
--to=sandeen@redhat.com \
--cc=gene@czarc.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.