From: dturvene <dturvene@dahetral.com>
To: linux-input@vger.kernel.org
Subject: Question about psmouse alps driver patches
Date: Fri, 25 Jan 2013 10:47:46 -0500 [thread overview]
Message-ID: <5102A922.4090203@dahetral.com> (raw)
I submitted normalized patches to Canonical Ubuntu in October for the
alps psmouse touchpad. The thread is long and confusing at
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/606238
Since then, I have maintained a psmouse dlkm that provides alps support
for a number of new systems, primarily from Dell.
Recently, I have been asked by several people to submit the patches to
linux-input to merge into the upstream kernel. I am looking for advice
on how to proceed. The big problems are:
1) The alps touchpads seem to be mutating relatively quickly with
several unrecognized signatures appearing over the last few months after
I built my patches.
2) A number of people have submitted a patch for a particular alps
touchpad signature, which will need to be reconciled and rolled-up into
a single driver. See the Jan 20 3-part submission by
cernekee@gmail.com. His patches look good, and clean up the code a good
bit, but target a touchpad signature also reverse-engineered by
bgarami.foss@gmail.com. I integrated the bgarami fixes into my patches
but the patches from cernekee@gmail.com are radically different.
3) I built the patches against the 3.2 kernel. My understanding is they
do not even compile against the kernel head - something like 3.5.x.
I feel bad submitting the patches I have. They are big and rough
because several of us reverse-engineered the ALPS interfaces but did not
try to figure them out. It will take a lot of merge+test work to
reconcile the patch submissions for the various alps target platforms.
What do you suggest I do (e.g. submit a patch for only the new protocol
I can test?)
next reply other threads:[~2013-01-25 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 15:47 dturvene [this message]
2013-01-26 11:10 ` Question about psmouse alps driver patches Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5102A922.4090203@dahetral.com \
--to=dturvene@dahetral.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.