From: Jeff Garzik <jgarzik@pobox.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: linux-ide@vger.kernel.org, linux-pm@vger.kernel.org,
linux-acpi@vger.kernel.org, Aaron Lu <aaron.lwe@gmail.com>,
Jeff Wu <jeff.wu@amd.com>, Tejun Heo <tj@kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH v2 2/2] libata: PM code cleanup for ata port
Date: Fri, 25 Jan 2013 15:34:03 -0500 [thread overview]
Message-ID: <5102EC3B.9040901@pobox.com> (raw)
In-Reply-To: <510226F9.5000709@intel.com>
On 01/25/2013 01:32 AM, Aaron Lu wrote:
> For system freeze, if the port is already runtime suspended, leave it
> alone and just return. The port will be resumed on thaw before it will
> be used.
>
> And since we will call get_noresume for every device during prepare
> phase, and the port is resumed during thaw phase, it can't be in runtime
> suspended state during the poweroff phase. So remove the
> runtime_suspended check in poweroff callback.
>
> And for all suspend(freeze/suspend/poweroff/etc.), there is no need to
> touch the device, so set no_autopsy and no_recovery for them all.
>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
> drivers/ata/libata-core.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
applied 1-2
prev parent reply other threads:[~2013-01-25 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 8:49 [PATCH] libata: pm: differentiate system and runtime pm for ata port Aaron Lu
2013-01-21 20:44 ` Jeff Garzik
2013-01-22 8:48 ` Aaron Lu
2013-01-25 6:29 ` [PATCH v2 1/2] " Aaron Lu
2013-01-25 6:32 ` [PATCH v2 2/2] libata: PM code cleanup " Aaron Lu
2013-01-25 11:33 ` Sergei Shtylyov
2013-01-25 12:29 ` Rafael J. Wysocki
2013-01-25 20:34 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5102EC3B.9040901@pobox.com \
--to=jgarzik@pobox.com \
--cc=aaron.lu@intel.com \
--cc=aaron.lwe@gmail.com \
--cc=jeff.wu@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.