All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/2] ARM: davinci: Remoteproc driver support for OMAP-L138 DSP
Date: Sat, 26 Jan 2013 19:21:32 +0400	[thread overview]
Message-ID: <5103F47C.4020509@mvista.com> (raw)
In-Reply-To: <1359168322-17733-2-git-send-email-rtivy@ti.com>

Hello.

On 26-01-2013 6:45, Robert Tivy wrote:

> Adding a remoteproc driver implementation for OMAP-L138 DSP

> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> new file mode 100644
> index 0000000..c6eb6bf
> --- /dev/null
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -0,0 +1,327 @@
[...]
> +#define SYSCFG_CHIPSIG_OFFSET 0x174
> +#define SYSCFG_CHIPSIG_CLR_OFFSET 0x178

    Wait, you don't even use these #define's -- why they're here at all?

WBR, Sergei

  parent reply	other threads:[~2013-01-26 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1359168322-17733-1-git-send-email-rtivy@ti.com>
     [not found] ` <1359168322-17733-3-git-send-email-rtivy@ti.com>
2013-01-26 14:42   ` [PATCH v6 2/2] ARM: davinci: Remoteproc platform device creation data/code Sergei Shtylyov
2013-01-29  1:31     ` Tivy, Robert
     [not found] ` <1359168322-17733-2-git-send-email-rtivy@ti.com>
2013-01-26 14:32   ` [PATCH v6 1/2] ARM: davinci: Remoteproc driver support for OMAP-L138 DSP Sergei Shtylyov
2013-01-30  2:28     ` Tivy, Robert
2013-01-26 15:21   ` Sergei Shtylyov [this message]
2013-01-28 23:56     ` Tivy, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5103F47C.4020509@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.