From: Antti Palosaari <crope@iki.fi>
To: Jose Alberto Reguero <jareguero@telefonica.net>
Cc: LMML <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Add lock to af9035 driver for dual mode
Date: Sun, 27 Jan 2013 11:26:39 +0200 [thread overview]
Message-ID: <5104F2CF.7080205@iki.fi> (raw)
In-Reply-To: <2105558.TtkZgv1BCF@jar7.dominio>
On 01/27/2013 02:10 AM, Jose Alberto Reguero wrote:
> On Jueves, 24 de enero de 2013 10:43:44 Antti Palosaari escribió:
>> On 01/24/2013 02:15 AM, Jose Alberto Reguero wrote:
>>> On Jueves, 24 de enero de 2013 00:36:25 Antti Palosaari escribió:
>>>> On 01/24/2013 12:34 AM, Jose Alberto Reguero wrote:
>>>>> Add lock to af9035 driver for dual mode.
>>>>
>>>> May I ask why you do that?
>>>>
>>>> regards
>>>> Antti
>>>
>>> Just to avoid interference between the two demods.
>>>
>>> Jose Alberto
>>
>> ... and how you can see that interference? What should I do that I can
>> see these problems you are trying to fix with that patch.
>>
>> regards
>> Antti
>
> It is not to fix any real problem. It is to avoid concurrent access to both
> demods to prevent bad effects.
>
> Jose Alberto
You copy & pasted it from the AF9015 driver. The reason why it is there
is firmware, which has some problems if it was interrupted in some
cases. Like you were asking BER from the demod and then tuner access was
done using same I2C adapter. AF9015 firmware offers I2C adapter for 2
demod and 2 RF-tuners. First demod is integrated and is memory mapped -
but what I remember you could access it via I2C too. AF9015 fw also has
internally some logic, it access to tuner and demod registers directly.
Those locks seen in AF9015 driver are mostly due to af9015 firmware
limitations and should not be copied to the any other driver without a
real need. AF9035 fw seems to behave a better.
regards
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2013-01-27 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 22:34 [PATCH] Add lock to af9035 driver for dual mode Jose Alberto Reguero
2013-01-23 22:36 ` Antti Palosaari
2013-01-24 0:15 ` Jose Alberto Reguero
2013-01-24 8:43 ` Antti Palosaari
2013-01-27 0:10 ` Jose Alberto Reguero
2013-01-27 9:26 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5104F2CF.7080205@iki.fi \
--to=crope@iki.fi \
--cc=jareguero@telefonica.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.