From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1TzU73-00055R-Sd for mharc-grub-devel@gnu.org; Sun, 27 Jan 2013 10:25:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzU6z-00052b-9b for grub-devel@gnu.org; Sun, 27 Jan 2013 10:25:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzU6x-000068-Bq for grub-devel@gnu.org; Sun, 27 Jan 2013 10:25:37 -0500 Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]:64488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzU6x-00005H-5F for grub-devel@gnu.org; Sun, 27 Jan 2013 10:25:35 -0500 Received: by mail-we0-f173.google.com with SMTP id r5so993644wey.18 for ; Sun, 27 Jan 2013 07:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=6hWGus65CtemHqvHiynoXabH18nfvfHbmSFz6BOGg00=; b=p3uiwkTs+j9gon94PfEe4vejqJrVb1WUkDxv85a7us0PDFfr27+wpSZGO3R2J7mKwS FXSqXFzVEMbrSASp8JlAouyidhwkUdl87eBjd4BKXjKxPI+bPEUuPVkTrKom/Wdxf7Eg IF/8oxfSuhFgoHPkJ8ArOrbq53/HJw8QgFY60u70WKtD/R15sHR8sLWC4mCcMxEIG04x voVibbL3BzrTA7Pn7An+OcWELIOp5F7REGflBpep3iWvgIILfNaDPvdoqbdDzYypnVj4 s8uR+03TWv3g131I0q+f71KbP96Gvqiohz032LkZT0qh29KozFcMHER83IR8w4ZuNobt pbaA== X-Received: by 10.180.100.163 with SMTP id ez3mr5441620wib.32.1359299919053; Sun, 27 Jan 2013 07:18:39 -0800 (PST) Received: from debian.x201.phnet (33-233.197-178.cust.bluewin.ch. [178.197.233.33]) by mx.google.com with ESMTPS id hu8sm7726516wib.6.2013.01.27.07.18.35 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 27 Jan 2013 07:18:38 -0800 (PST) Message-ID: <51054548.2000908@gmail.com> Date: Sun, 27 Jan 2013 16:18:32 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] change misleading comment about device.map in grub-install References: <1358874068-31100-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1358874068-31100-1-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig5401FBCD664597A24F6A7FEB" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jan 2013 15:25:39 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5401FBCD664597A24F6A7FEB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Comitted, thanks. On 22.01.2013 18:01, Andrey Borzenkov wrote: > grub-install is not supposed to create device.map; change comment > to avoid confusion. It was already considered a bug by users. >=20 > Signed-off-by: Andrey Borzenkov >=20 > --- > ChangeLog | 5 +++++ > util/grub-install.in | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/ChangeLog b/ChangeLog > index 8c4d087..61dda4e 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2013-01-22 Andrey Borzenkov > + > + * util/grub-install.in: change misleading comment about > + device.map creation > + > 2013-01-22 Colin Watson > =20 > * util/grub-reboot.in (usage): Document the need for > diff --git a/util/grub-install.in b/util/grub-install.in > index aac27c7..9e63cf5 100644 > --- a/util/grub-install.in > +++ b/util/grub-install.in > @@ -505,7 +505,7 @@ if test $recheck =3D yes; then > rm -f "$device_map" > fi > =20 > -# Create the device map file if it is not present. > +# Device map file is optional > if test -f "$device_map"; then > # Make sure that there is no duplicated entry. > tmp=3D`sed -n '/^([fh]d[0-9]*)/s/\(^(.*)\).*/\1/p' "$device_map" \= --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig5401FBCD664597A24F6A7FEB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlEFRUkACgkQNak7dOguQglbaAEAofTRClFXstb61o9Iq57iwhFP 9f12MHalJufIIj8CbOsA/1FnejbZXkzbpZVoeoBAnhY/4JMonRterv4PPmZ3YFfX =zxL8 -----END PGP SIGNATURE----- --------------enig5401FBCD664597A24F6A7FEB--