Re: [PATCH 3/4] ARM: dts: add support for hdmi-ddc to exynos4412-origen

[Sylwester Nawrocki <sylvester.nawrocki@gmail.com>]

Hi,

On 01/25/2013 11:39 AM, Rahul Sharma wrote:
> Signed-off-by: Rahul Sharma<rahul.sharma@samsung.com>

Please explain why this patch is needed, in more detail...

> ---
>   arch/arm/boot/dts/exynos4.dtsi          |  1 -
>   arch/arm/boot/dts/exynos4412-origen.dts | 13 +++++++++++++
>   2 files changed, 13 insertions(+), 1 deletion(-)
>   mode change 100644 =>  100755 arch/arm/boot/dts/exynos4412.dtsi
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 07cb7d4..a75e2f5 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -219,7 +219,6 @@
>   		compatible = "samsung,s3c2440-i2c";
>   		reg =<0x138C0000 0x100>;
>   		interrupts =<0 64 0>;
> -		status = "disabled";

No, it's not how it is supposed to be done. If you want to enable
this specific I2C controller on your board, just add status = "okay";
line in its node in the board-specific dts file. Please see below.

>   	};
>
>   	i2c_7: i2c@138D0000 {
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> index 4eba374..6299f1b 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -59,4 +59,17 @@
>   	serial@13830000 {
>   		status = "okay";
>   	};
> +
> +	i2c_6: i2c@138C0000 {
> +		samsung,i2c-sda-delay =<100>;
> +		samsung,i2c-max-bus-freq =<66000>;
> +
> +		pinctrl-0 =<&i2c6_bus>;
> +		pinctrl-names = "default";

		status = "okay";

> +		hdmiddc@50 {
> +			compatible = "samsung,exynos4-hdmiddc";
> +			reg =<0x50>;
> +		};
> +	};
>   };
> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> old mode 100644
> new mode 100755

Are you sure you need to add all these execute permissions ?
Do you think these values are more sane than the previous ones ?
I'm afraid there is something going wrong with the file permissions
in your environment...

--

Thanks,
Sylwester