Re: [PATCH] xenguest: Add xsa-25 decompression limit prototypes

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 28/01/13 09:25, Ian Campbell wrote:
> On Fri, 2013-01-25 at 18:04 +0000, Andrew Cooper wrote:
>> To allow xenguest consumers to also make use of the extra protection added as
>> a result of xsa-25.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>> diff -r 5af4f2ab06f3 -r daec50a41570 tools/libxc/xenguest.h
>> --- a/tools/libxc/xenguest.h
>> +++ b/tools/libxc/xenguest.h
>> @@ -177,6 +177,13 @@ int xc_dom_linux_build(xc_interface *xch
>>  		       unsigned int console_evtchn,
>>  		       unsigned long *console_mfn);
>>  
>> +#ifndef XC_HAVE_DECOMPRESS_LIMITS
>> +#define XC_HAVE_DECOMPRESS_LIMITS
>> +#endif
> This sort of thing isn't in general needed for the libxc interface,
> which already makes very little in the way of API stability guarantees.
> The only existing example uses XENCTRL_HAS_* so if this is really felt
> to be useful it should match.
>
> Also this file has multiple inclusion guards so the ifndef really isn't
> necessary.
>
>> +int xc_dom_kernel_max_size(struct xc_dom_image *dom, size_t sz);
>> +int xc_dom_ramdisk_max_size(struct xc_dom_image *dom, size_t sz);
> These duplicate the ones in xc_dom.h, if the prototypes there aren't
> sufficient then they should be moved not repeated.

xenguest.h includes no files whatsoever, and every single prototype in
it is a duplicate of other functions in xc_*.h header files.  This
appears to be the point.  Furthermore, it is the only file referenced by
the ocaml subs for libxc, and the xenguest helper utility for Xapi.

~Andrew

>
>> +
>>  /**
>>   * This function will create a domain for a paravirtualized Linux
>>   * using buffers for kernel and initrd
>