Re: [PATCH V3 7/10] MIPS: ralink: adds early_printk support

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 28-01-2013 11:40, John Crispin wrote:

> Add the code needed to make early printk work.

> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
>   arch/mips/ralink/early_printk.c |   45 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 45 insertions(+)
>   create mode 100644 arch/mips/ralink/early_printk.c

> diff --git a/arch/mips/ralink/early_printk.c b/arch/mips/ralink/early_printk.c
> new file mode 100644
> index 0000000..68aabb9
> --- /dev/null
> +++ b/arch/mips/ralink/early_printk.c
> @@ -0,0 +1,45 @@
> +/*
> + *  This program is free software; you can redistribute it and/or modify it
> + *  under the terms of the GNU General Public License version 2 as published
> + *  by the Free Software Foundation.
> + *
> + *  Copyright (C) 2011-2012 Gabor Juhos <juhosg@openwrt.org>
> + */
> +
> +#include <linux/io.h>
> +#include <linux/serial_reg.h>
> +
> +#include <asm/addrspace.h>
> +
> +/* UART registers */

    this comment refers to the register #defines below, why it is here?

> +#define EARLY_UART_BASE         0x10000c00
> +
> +#define UART_REG_RX             0x00
> +#define UART_REG_TX             0x04
> +#define UART_REG_IER            0x08
> +#define UART_REG_IIR            0x0c
> +#define UART_REG_FCR            0x10
> +#define UART_REG_LCR            0x14
> +#define UART_REG_MCR            0x18
> +#define UART_REG_LSR            0x1c

WBR, Sergei