From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lord Glauber Costa of Sealand Subject: Re: [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap. Date: Mon, 28 Jan 2013 18:41:39 +0400 Message-ID: <51068E23.5040000@parallels.com> References: <87ehh8it9s.fsf@xmission.com> <87zjzwhegj.fsf@xmission.com> <20130128142816.GU17632@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: "Eric W. Biederman" , , Linux Containers , , Andrew Morton To: Aristeu Rozanski Return-path: Received: from mx2.parallels.com ([64.131.90.16]:38247 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756969Ab3A1OlW (ORCPT ); Mon, 28 Jan 2013 09:41:22 -0500 In-Reply-To: <20130128142816.GU17632@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hello Mr. Someone. On 01/28/2013 06:28 PM, Aristeu Rozanski wrote: > On Fri, Jan 25, 2013 at 06:21:00PM -0800, Eric W. Biederman wrote: >> When I initially wrote the code for /proc//uid_map. I was lazy >> and avoided duplicate mappings by the simple expedient of ensuring the >> first number in a new extent was greater than any number in the >> previous extent. >> >> Unfortunately that precludes a number of valid mappings, and someone >> noticed and complained. So use a simple check to ensure that ranges >> in the mapping extents don't overlap. > > Acked-by: Someone > Documentation/SubmittingPatches: "then you just add a line saying Signed-off-by: Random J Developer using your real name (sorry, no pseudonyms or anonymous contributions.)" I know how it feels, but that is how it goes. You'll have to change that.