All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Prashant Gaikwad
	<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2/2] clk: tegra: add ac97 controller clock
Date: Mon, 28 Jan 2013 14:17:55 -0700	[thread overview]
Message-ID: <5106EB03.6080606@wwwdotorg.org> (raw)
In-Reply-To: <1359401144.1558.11.camel@tellur>

On 01/28/2013 12:25 PM, Lucas Stach wrote:
> Am Montag, den 28.01.2013, 12:15 -0700 schrieb Stephen Warren:
>> On 01/27/2013 03:17 PM, Lucas Stach wrote:
>>> AC97 controller clock is hardwired to pll_a_out0.
>>
>> One more comment here; don't you need to add this clock into
>> audio_parents[]?
>>
> Yeah it's documented that AC97 can be used as audio_sync_clock, but for
> one I haven't tested this

I expect there are quite a few of the clock driver table entries that
aren't tested. I still think we should add them though, once the clocks
they refer to actually exist.

> and also ac97 clock == pll_a_out0, so you can
> just as well use the pll out in that case.

I suspect that "ac97 clock == pll_a_out0" isn't categorically true; it's
quite possible that the TRM simply doesn't document the mux
register/field for the ac97 clock since the ac97 module is considered
deprecated. The diagram at the end of section 5.2.3 "Audio Clocks"
certainly implies that all of the i2s*, spdifout, and ac97 clocks have
the same structure.

  reply	other threads:[~2013-01-28 21:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-27 22:17 [PATCH 1/2] clk: tegra: remove USB from clk init table Lucas Stach
     [not found] ` <1359325055-5160-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-01-27 22:17   ` [PATCH 2/2] clk: tegra: add ac97 controller clock Lucas Stach
     [not found]     ` <1359325055-5160-2-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-01-28 18:38       ` Stephen Warren
2013-01-28 19:15       ` Stephen Warren
     [not found]         ` <5106CE6D.9030008-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-28 19:25           ` Lucas Stach
2013-01-28 21:17             ` Stephen Warren [this message]
     [not found]               ` <5106EB03.6080606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-30  9:35                 ` Peter De Schrijver
     [not found]                   ` <20130130093525.GC2364-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-01-30 18:27                     ` Stephen Warren
     [not found]                       ` <51096618.3000100-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-21 14:01                         ` Lucas Stach
2013-03-21 17:48                           ` Stephen Warren
2013-01-28 18:37   ` [PATCH 1/2] clk: tegra: remove USB from clk init table Stephen Warren
     [not found]     ` <5106C583.7010204-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-28 18:45       ` Lucas Stach
2013-01-28 19:13         ` Stephen Warren
     [not found]           ` <5106CDCD.2020101-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-28 19:23             ` Lucas Stach
2013-01-28 21:15               ` Stephen Warren
2013-01-30  9:32       ` Peter De Schrijver
  -- strict thread matches above, loose matches on Subject: below --
2013-05-06 21:11 [PATCH 0/2] ARM: tegra: a couple clock bug-fixes Stephen Warren
     [not found] ` <1367874671-11474-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-06 21:11   ` [PATCH 2/2] clk: tegra: add ac97 controller clock Stephen Warren
2013-05-06 21:11     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5106EB03.6080606@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.