Re: [PATCH] Btrfs-progs: v2 Fix minor problems in btrfslabel.c

[Jeff Liu <jeff.liu@oracle.com>]

Hi David,

On 01/29/2013 12:16 AM, David Sterba wrote:
> On Sat, Jan 26, 2013 at 01:09:56PM -0500, Gene Czarcinski wrote:
>> Fixed indentation, replace spaces with tabs.
>> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
>>
>> Rebased; fixed compiler warnings; added space after "if"
>> Signed-off-by: Gene Czarcinski <gene@czarc.net>
>> ---
>>  btrfslabel.c | 57 +++++++++++++++++++++++++++++----------------------------
> 
> Jeff Liu has sent a series that updates the code and also fixes the
> formatting. And I'd prefer to take his series as a more extensive
> update.
> 
> Also, btrfslabel.c is another file to be removed and its contents placed
> into the right locations, like cmds-filesystem.c or util.[ch] . I didn't
> realize that during reviewing the label series.
> 
> Jeff, I suggest to add a new patch that moves the functions out of
> btrfslabel.c, so you don't have to rework the whole series again.
I'll deal with it later, Thanks for your kind suggestion.

-Jeff