From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx197.postini.com [74.125.245.197]) by kanga.kvack.org (Postfix) with SMTP id 86BE66B000C for ; Tue, 29 Jan 2013 05:21:35 -0500 (EST) Message-ID: <5107A2B8.4070505@parallels.com> Date: Tue, 29 Jan 2013 14:21:44 +0400 From: Lord Glauber Costa of Sealand MIME-Version: 1.0 Subject: Re: [PATCHv2 8/9] zswap: add to mm/ References: <1357590280-31535-1-git-send-email-sjenning@linux.vnet.ibm.com> <1357590280-31535-9-git-send-email-sjenning@linux.vnet.ibm.com> <51030ADA.8030403@redhat.com> <510698F5.5060205@linux.vnet.ibm.com> In-Reply-To: <510698F5.5060205@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Seth Jennings Cc: Rik van Riel , Greg Kroah-Hartman , Andrew Morton , Nitin Gupta , Minchan Kim , Konrad Rzeszutek Wilk , Dan Magenheimer , Robert Jennings , Jenifer Hopper , Mel Gorman , Johannes Weiner , Larry Woodman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org On 01/28/2013 07:27 PM, Seth Jennings wrote: > Yes, I prototyped a shrinker interface for zswap, but, as we both > figured, it shrinks the zswap compressed pool too aggressively to the > point of being useless. Can't you advertise a smaller number of objects that you actively have? Since the shrinker would never try to shrink more objects than you advertised, you could control pressure this way. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145Ab3A2KVg (ORCPT ); Tue, 29 Jan 2013 05:21:36 -0500 Received: from mx2.parallels.com ([64.131.90.16]:46719 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167Ab3A2KVb (ORCPT ); Tue, 29 Jan 2013 05:21:31 -0500 Message-ID: <5107A2B8.4070505@parallels.com> Date: Tue, 29 Jan 2013 14:21:44 +0400 From: Lord Glauber Costa of Sealand User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Seth Jennings CC: Rik van Riel , Greg Kroah-Hartman , Andrew Morton , Nitin Gupta , Minchan Kim , "Konrad Rzeszutek Wilk" , Dan Magenheimer , Robert Jennings , Jenifer Hopper , Mel Gorman , "Johannes Weiner" , Larry Woodman , , , Subject: Re: [PATCHv2 8/9] zswap: add to mm/ References: <1357590280-31535-1-git-send-email-sjenning@linux.vnet.ibm.com> <1357590280-31535-9-git-send-email-sjenning@linux.vnet.ibm.com> <51030ADA.8030403@redhat.com> <510698F5.5060205@linux.vnet.ibm.com> In-Reply-To: <510698F5.5060205@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2013 07:27 PM, Seth Jennings wrote: > Yes, I prototyped a shrinker interface for zswap, but, as we both > figured, it shrinks the zswap compressed pool too aggressively to the > point of being useless. Can't you advertise a smaller number of objects that you actively have? Since the shrinker would never try to shrink more objects than you advertised, you could control pressure this way.