From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH 2/2] xl: allow specifying a default netdev
 in xl.conf
Date: Tue, 29 Jan 2013 11:01:05 +0000
Message-ID: <5107ABF1.5080609@citrix.com>
References: <1359127583-32490-1-git-send-email-roger.pau@citrix.com>
	<1359127583-32490-3-git-send-email-roger.pau@citrix.com>
	<CAFLBxZa2d-iq5cFn+aBqmQG3-GNE9MrwuXE3zEcU3Rvtas0M=w@mail.gmail.com>
	<CAFLBxZZxkcwOH2VaGbcERWs1Mo4NHTXSHrW5tRPYgpOoPB=dLw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZZxkcwOH2VaGbcERWs1Mo4NHTXSHrW5tRPYgpOoPB=dLw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ulf Kreutzberg <ulf.kreutzberg@hosteurope.de>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 28/01/13 17:11, George Dunlap wrote:
> On Mon, Jan 28, 2013 at 11:00 AM, George Dunlap
> <George.Dunlap@eu.citrix.com <mailto:George.Dunlap@eu.citrix.com>> wrote:
> 
>     On Fri, Jan 25, 2013 at 3:26 PM, Roger Pau Monne
>     <roger.pau@citrix.com <mailto:roger.pau@citrix.com>> wrote:
> 
>         This adds a new global option in the xl configuration file called
>         "defaultnetdev", that is used to specify the default netdev to use
>         when none is passed in the vif specification.
> 
> 
>     I'm not a fan of the name, though; it doesn't seem very scalable. 
>     It looks like we already have "defaultbridge', so I can see this is
>     just following precedent, but I wonder if it might be worth putting
>     some more thought into it before proceeding?
> 
>     It seems like if we're going to have a default sub-option, it should
>     at least have the name of the option in which it resides. 
>     "vif_netdev_default" or "default_vif_netdev" seem like better
>     option.  Or maybe "vif.netdev.default"? "defaults.vif.netdev"?

vif_default_netdev sounds good to me, but I don't have any opinions
against the others. We should also add vif_default_bridge (while keeping
the old option). Someone has a strong opinion about any of this names,
or should I just choose the one I prefer?

> 
>     Any thoughts?
> 
> 
> Also, it's probably worth thinking about what other options should have
> defaults.  vif.backend is another one that it seems like it would be
> useful to be able to override (e.g., to make it easy to switch to and
> from driver domains).

Yes, but this should be added when driver domains are done
(vif_default_domain/block_default_domain).