From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
rostedt@goodmis.org, fweisbec@gmail.com, rusty@rustcorp.com.au,
ananth@in.ibm.com, anil.s.keshavamurthy@intel.com,
jbaron@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org,
"yrl.pp-manager.tt@hitachi.com" <yrl.pp-manager.tt@hitachi.com>
Subject: Re: [PATCH 3/5] kprobes: constify check_kprobe_address_safe and friends
Date: Tue, 29 Jan 2013 20:45:52 +0900 [thread overview]
Message-ID: <5107B670.1000800@hitachi.com> (raw)
In-Reply-To: <51020566.6040408@oracle.com>
(2013/01/25 13:09), Sasha Levin wrote:
> As to arch_check_optimized_kprobe() and check_kprobe_address_safe(), this
> is simply way too confusing. It doesn't make sense that a function named
> check_[...]() would modify any of it's parameters.
>
> For example, that entire block within KPROBES_CAN_USE_FTRACE should be split
> out and go into update_kprobe_for_ftrace() or something similar.
>
> If that makes sense, I can send a patch to split out all the parts that
> modify anything in those two functions out of them.
I see, that makes sense :-)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2013-01-29 11:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 23:09 [PATCH 1/5] module: constify within_module_* Sasha Levin
2013-01-09 23:09 ` [PATCH 2/5] jump label: constify lookup functions Sasha Levin
2013-01-15 20:46 ` Sasha Levin
2013-01-15 23:19 ` Steven Rostedt
2013-01-18 21:25 ` Steven Rostedt
2013-01-21 6:51 ` Rusty Russell
2013-01-25 4:15 ` Sasha Levin
2013-01-25 10:16 ` Borislav Petkov
2013-01-25 13:03 ` Steven Rostedt
2013-01-18 21:25 ` Steven Rostedt
2013-01-09 23:09 ` [PATCH 3/5] kprobes: constify check_kprobe_address_safe and friends Sasha Levin
2013-01-21 11:49 ` Masami Hiramatsu
2013-01-25 4:09 ` Sasha Levin
2013-01-29 11:45 ` Masami Hiramatsu [this message]
2013-01-09 23:09 ` [PATCH 4/5] alternatives: constify alternatives_text_reserved Sasha Levin
2013-01-21 11:38 ` Masami Hiramatsu
2013-01-09 23:09 ` [PATCH 5/5] ftrace: constify ftrace_text_reserved Sasha Levin
2013-01-10 9:02 ` [PATCH 1/5] module: constify within_module_* Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5107B670.1000800@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.