From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/7] omap3: allow dynamic selection of gfx_format
Date: Tue, 29 Jan 2013 16:22:09 +0200 [thread overview]
Message-ID: <5107DB11.70707@compulab.co.il> (raw)
In-Reply-To: <20130129135209.BEC252A08AC@gemini.denx.de>
Hi Wolfgang Denk,
On 01/29/2013 03:52 PM, Wolfgang Denk wrote:
> Dear Nikita Kiryanov,
>
> In message <1359463349-11649-3-git-send-email-nikita@compulab.co.il> you wrote:
>> Currently the value of gfx_format is hardcoded into
>> omap3_dss_panel_config(). Make it a field in struct panel_config, and
>> update existing structs to set this field to the value that was originally hard
>> coded.
>
> It is not exactly clear to me what exactly this is needed for? Are
> you just adding dead code? if not, then please explain this in the
> commit message.
Currently if you want to use a gfx format other than what
omap3_dss_panel_config() sets, you have to change it manually.
It was suggested in the review of V1 that it would be better if this
value could simply be passed to omap3_dss_panel_config() so that
there wouldn't be a need for adjustments.
I'll try to rephrase the commit message to explain the benefits of this.
>
> Best regards,
>
> Wolfgang Denk
>
--
Regards,
Nikita.
next prev parent reply other threads:[~2013-01-29 14:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 12:42 [U-Boot] [PATCH V2 0/7] Add splash screen for CM-T35 Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V1 1/7] omap3: add useful dss defines Nikita Kiryanov
2013-01-29 13:55 ` Wolfgang Denk
2013-01-29 14:11 ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V2 2/7] omap3: allow dynamic selection of gfx_format Nikita Kiryanov
2013-01-29 13:52 ` Wolfgang Denk
2013-01-29 14:22 ` Nikita Kiryanov [this message]
2013-01-29 12:42 ` [U-Boot] [PATCH V2 3/7] lcd: prevent unaligned memory access when displaying splash screen Nikita Kiryanov
2013-01-29 13:46 ` Wolfgang Denk
2013-01-29 14:34 ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V1 4/7] lcd: add option for board specific splash screen preparation Nikita Kiryanov
2013-01-29 13:46 ` Wolfgang Denk
2013-01-29 14:44 ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V2 5/7] cm-t35: add support for dvi displays Nikita Kiryanov
2013-01-29 14:00 ` Wolfgang Denk
2013-01-29 15:04 ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V2 6/7] cm-t35: add support for user defined lcd parameters Nikita Kiryanov
2013-01-29 13:48 ` Wolfgang Denk
2013-01-30 8:00 ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V2 7/7] cm-t35: add support for loading splash image from NAND Nikita Kiryanov
2013-01-29 13:50 ` Wolfgang Denk
2013-01-30 8:08 ` Nikita Kiryanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5107DB11.70707@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.