All of lore.kernel.org
 help / color / mirror / Atom feed
From: lei yang <lei.yang@windriver.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: "meta-virtualization@yoctoproject.org"
	<meta-virtualization@yoctoproject.org>
Subject: Re: [PATCH] openvswtich: start openvswitch at the boot time
Date: Wed, 30 Jan 2013 00:32:57 +0800	[thread overview]
Message-ID: <5107F9B9.10500@windriver.com> (raw)
In-Reply-To: <CADkTA4N0LWxDXWSGnUzUQKgGWPEtZ0wyzNF4p9Jf68xTZ5uDWw@mail.gmail.com>

On 01/29/2013 09:46 PM, Bruce Ashfield wrote:
>
>
> On Mon, Jan 28, 2013 at 6:01 AM, <lei.yang@windriver.com 
> <mailto:lei.yang@windriver.com>> wrote:
>
>     From: Lei Yang <lei.yang@windriver.com
>     <mailto:lei.yang@windriver.com>>
>
>     When I define the bridge, I get below error
>
>     root@intel_5500_server:~# ovs-vsctl add-br ovsbr0
>     Jan 25 17:34:07|00002|stream_unix|ERR|/tmp/stream-unix.1487.0:
>     connection to /var/run/openvswitch/db.sock
>     failed: No such file or directory
>     ........
>     ........
>
>     This is becasue openvswitch isn't running,so we'd better start it
>     at the boot time.
>
>
> s/becasue/because/
>
> Can you elaborate on this a bit more as well. What you are actually 
> doing in the
> patch is adding to the RDEPENDS of openvswitch and it's the 
> dependencies that
> you are adding, that once installed are starting the switch at runtime 
> .. right ? The
> reason I'd like it clarified is that when I read your patch, I 
> expected to see an initscript
> update, or inherit rc.d, but found the RDEPENDS update instead.


because : those tow packages used rc.d. so we only need to install them

inherit autotools update-rc.d

INITSCRIPT_PACKAGES = "${PN}-switch ${PN}-controller"
INITSCRIPT_NAME_${PN}-switch = "openvswitch-switch"
INITSCRIPT_PARAMS_${PN}-switch = "defaults 71"

INITSCRIPT_NAME_${PN}-controller = "openvswitch-controller"
INITSCRIPT_PARAMS_${PN}-controller = "defaults 72"


I will send V2 tomorrow

LeI





>     Since openvswtich depends on openvswtich module,so auto load the
>     kernel module too.
>
>
>     Signed-off-by: Lei Yang <lei.yang@windriver.com
>     <mailto:lei.yang@windriver.com>>
>     Tested-by: Lei Yang <lei.yang@windriver.com
>     <mailto:lei.yang@windriver.com>>
>     ---
>      recipes-kernel/linux/linux-yocto_3.4.bbappend      |    2 +-
>      .../openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>               |    2 +-
>      2 files changed, 2 insertions(+), 2 deletions(-)
>
>     diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
>     b/recipes-kernel/linux/linux-yocto_3.4.bbappend
>     index 5b163ff..918302a 100644
>     --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
>     +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
>     @@ -5,4 +5,4 @@ SRC_URI += "file://xt-checksum.scc \
>                 file://vswitch.scc \
>                 file://lxc.scc \
>                 "
>     -
>     +module_autoload_openvswitch = "openvswitch"
>
>
> This looks fine. I double checked that the vswitch kernel fragment 
> enables the module,
> so our autoload is fine.
>
> Bruce
>
>     diff --git a/recipes-networking/openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>
>     b/recipes-networking/openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>
>     index 88f0114..6764073 100644
>     --- a/recipes-networking/openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>
>     +++ b/recipes-networking/openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>
>     @@ -7,7 +7,7 @@ LICENSE = "Apache-2"
>      DEPENDS += "bridge-utils openssl python perl"
>
>      RDEPENDS_${PN} += "util-linux-uuidgen util-linux-libuuid \
>     -              python perl perl-module-strict"
>     +              python perl perl-module-strict ${PN}-switch
>     ${PN}-controller"
>      RDEPENDS_${PN}-controller = "${PN} lsb ${PN}-pki"
>      RDEPENDS_${PN}-switch = "${PN} openssl procps util-linux-uuidgen"
>      RDEPENDS_${PN}-pki = "${PN}"
>     --
>     1.7.1
>
>     _______________________________________________
>     meta-virtualization mailing list
>     meta-virtualization@yoctoproject.org
>     <mailto:meta-virtualization@yoctoproject.org>
>     https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
>
> -- 
> "Thou shalt not follow the NULL pointer, for chaos and madness await 
> thee at its end"
>
>
> On Mon, Jan 28, 2013 at 6:01 AM, <lei.yang@windriver.com 
> <mailto:lei.yang@windriver.com>> wrote:
>
>     From: Lei Yang <lei.yang@windriver.com
>     <mailto:lei.yang@windriver.com>>
>
>     When I define the bridge, I get below error
>
>     root@intel_5500_server:~# ovs-vsctl add-br ovsbr0
>     Jan 25 17:34:07|00002|stream_unix|ERR|/tmp/stream-unix.1487.0:
>     connection to /var/run/openvswitch/db.sock
>     failed: No such file or directory
>     ........
>     ........
>
>     This is becasue openvswitch isn't running,so we'd better start it
>     at the boot time.
>     Since openvswtich depends on openvswtich module,so auto load the
>     kernel module too.
>
>     Signed-off-by: Lei Yang <lei.yang@windriver.com
>     <mailto:lei.yang@windriver.com>>
>     Tested-by: Lei Yang <lei.yang@windriver.com
>     <mailto:lei.yang@windriver.com>>
>     ---
>      recipes-kernel/linux/linux-yocto_3.4.bbappend      |    2 +-
>      .../openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>               |    2 +-
>      2 files changed, 2 insertions(+), 2 deletions(-)
>
>     diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
>     b/recipes-kernel/linux/linux-yocto_3.4.bbappend
>     index 5b163ff..918302a 100644
>     --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
>     +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
>     @@ -5,4 +5,4 @@ SRC_URI += "file://xt-checksum.scc \
>                 file://vswitch.scc \
>                 file://lxc.scc \
>                 "
>     -
>     +module_autoload_openvswitch = "openvswitch"
>     diff --git a/recipes-networking/openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>
>     b/recipes-networking/openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>
>     index 88f0114..6764073 100644
>     --- a/recipes-networking/openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>
>     +++ b/recipes-networking/openvswitch/openvswitch_1.4.3.bb
>     <http://openvswitch_1.4.3.bb>
>     @@ -7,7 +7,7 @@ LICENSE = "Apache-2"
>      DEPENDS += "bridge-utils openssl python perl"
>
>      RDEPENDS_${PN} += "util-linux-uuidgen util-linux-libuuid \
>     -              python perl perl-module-strict"
>     +              python perl perl-module-strict ${PN}-switch
>     ${PN}-controller"
>      RDEPENDS_${PN}-controller = "${PN} lsb ${PN}-pki"
>      RDEPENDS_${PN}-switch = "${PN} openssl procps util-linux-uuidgen"
>      RDEPENDS_${PN}-pki = "${PN}"
>     --
>     1.7.1
>
>     _______________________________________________
>     meta-virtualization mailing list
>     meta-virtualization@yoctoproject.org
>     <mailto:meta-virtualization@yoctoproject.org>
>     https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
>
> -- 
> "Thou shalt not follow the NULL pointer, for chaos and madness await 
> thee at its end"



  reply	other threads:[~2013-01-29 16:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28 11:01 [PATCH] openvswtich: start openvswitch at the boot time lei.yang
2013-01-29 13:46 ` Bruce Ashfield
2013-01-29 16:32   ` lei yang [this message]
2013-01-29 16:46     ` Bruce Ashfield
  -- strict thread matches above, loose matches on Subject: below --
2013-01-31  7:18 lei.yang
2013-01-31 13:39 ` Bruce Ashfield
2013-02-01  3:54   ` lei yang
2013-02-01 14:10     ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5107F9B9.10500@windriver.com \
    --to=lei.yang@windriver.com \
    --cc=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.