From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Subject: Re: [PATCH v3 1/3] drm: add prime helpers
Date: Tue, 29 Jan 2013 17:59:01 +0100
Message-ID: <5107FFD5.7020409@canonical.com>
References: <1358282864-2888-1-git-send-email-aplattner@nvidia.com>
	<1358282864-2888-2-git-send-email-aplattner@nvidia.com>
	<20130116095014.GB8347@phenom.ffwll.local>
	<50F7397B.8090003@nvidia.com>
	<CAKMK7uF-AdgoW_aHmVYu_nCkq=9hx0uUt_RAsUdaH7JkCsdmsQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from youngberry.canonical.com (youngberry.canonical.com
	[91.189.89.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id 29152E68DC
	for <dri-devel@lists.freedesktop.org>;
	Tue, 29 Jan 2013 08:59:04 -0800 (PST)
In-Reply-To: <CAKMK7uF-AdgoW_aHmVYu_nCkq=9hx0uUt_RAsUdaH7JkCsdmsQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

Op 17-01-13 09:40, Daniel Vetter schreef:
> On Thu, Jan 17, 2013 at 12:36 AM, Aaron Plattner <aplattner@nvidia.com> wrote:
>> Can I consider this a Reviewed-by?
> Essentially it was just a drive-by bikeshed ;-) I think it'd be good
> if Maarten takes a look at this and checks whether it complies with
> his massive prime/dma_buf rework to use fences and ticketing
> reservations ...
> -Daniel
Looks ok to me, I just wish there was a unpin being called on dma-buf release or if dma_buf_export fails, instead of only implicitly during destruction.
But that's something you couldn't have known, since it seems darktama still didn't accept my patch for that. :(

~Maarten