Re: intel-gpu-tools patches for read/write MMIO

[Daniel Vetter <daniel.vetter@intel.com>]

On 29/01/2013 21:01, Jesse Barnes wrote:
> Can you just post them externally tointel-gfx@lists.freedesktop.org?
> It's best to use git send-email to do it, that way the changelogs are
> preserved and posted to the ml along with the patches.
Public intel-gfx is already on the cc list, just in case you get the 
urge to spill some secrets ;-)
> Not sure if there's a bunch of duplication between the two, but you
> could split them up a bit.
>
> I still don't like the idea of silently adding the display offset on
> vlv; these are just debug tools and the developer should get the
> absolute offset they asked for no matter what.
On that topic of silently adding display offset - with Ville's kernel 
work we'll have switched away completely from such tricks in the kernel. 
So I think i-g-t shouldn't automatically add the offset.

Which essentially just leaves us with intel_reg_dumper. Now for that I'm 
somewhat hopefully that we will be able to (eventually) dump registers 
using the bspec xml sources (there should be bspec xmls around for just 
the open-source approved parts). In the meantime, can't we just adjust 
the relevant offsets of the register blocks? IIrc their all somewhat 
usefully grouped together, so this would amount to adding a quick 
function to add the offset to a given table (put keep all the names) and 
then feed the adjusted table to the dumper functions ...
-Daniel
Intel Semiconductor AG
Registered No. 020.30.913.786-7
Registered Office: World Trade Center, Leutschenbachstrasse 95, 8050 Zurich, Switzerland

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.