From: "H. Peter Anvin" <hpa@zytor.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Alec Bickerton <alec@theangrymob.co.uk>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Add Intel Ivy bridge CPU flags
Date: Tue, 29 Jan 2013 19:34:27 -0800 [thread overview]
Message-ID: <510894C3.1020605@zytor.com> (raw)
In-Reply-To: <20130124174148.GA15499@merkur.ravnborg.org>
On 01/24/2013 09:41 AM, Sam Ravnborg wrote:
>
>> --- a/arch/x86/Makefile_32.cpu
>> +++ b/arch/x86/Makefile_32.cpu
>> @@ -33,6 +33,7 @@ cflags-$(CONFIG_MCYRIXIII) += $(call cc-option,-march=c3,-march=i486) $(align)-f
>> cflags-$(CONFIG_MVIAC3_2) += $(call cc-option,-march=c3-2,-march=i686)
>> cflags-$(CONFIG_MVIAC7) += -march=i686
>> cflags-$(CONFIG_MCORE2) += -march=i686 $(call tune,core2)
>> +cflags-$(CONFIG_MIVYBRIDGE) += -march=i686 $(call tune,core-avx-i)
>> cflags-$(CONFIG_MATOM) += $(call cc-option,-march=atom,$(call cc-option,-march=core2,-march=i686)) \
>> $(call cc-option,-mtune=atom,$(call cc-option,-mtune=generic))
>
> Not a fault in your patch - but the x86 guys should learn to use the
> X86_ prefix on x86 specific config symbols :-(
> For consistency do not add it.
>
These are some of the oldest config symbols in the entire kernel.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2013-01-30 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 17:43 [PATCH] Add Intel Ivy bridge CPU flags Alec Bickerton
2013-01-24 10:53 ` Michal Marek
2013-01-24 11:13 ` Borislav Petkov
2013-01-24 17:41 ` Sam Ravnborg
2013-01-30 3:34 ` H. Peter Anvin [this message]
2013-01-31 18:45 ` Alec Bickerton
2013-02-14 23:41 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510894C3.1020605@zytor.com \
--to=hpa@zytor.com \
--cc=alec@theangrymob.co.uk \
--cc=linux-kbuild@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.