All of lore.kernel.org
 help / color / mirror / Atom feed
From: matthieu.castet@parrot.com (Matthieu CASTET)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] usb: chipidea: add PTW and PTS handling
Date: Wed, 30 Jan 2013 17:54:54 +0100	[thread overview]
Message-ID: <5109505E.7040204@parrot.com> (raw)
In-Reply-To: <1359559782-14552-5-git-send-email-s.hauer@pengutronix.de>

> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 57cae1f..dcb650f 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -67,6 +67,8 @@
>  #include <linux/usb/gadget.h>
>  #include <linux/usb/otg.h>
>  #include <linux/usb/chipidea.h>
> +#include <linux/usb/of.h>
> +#include <linux/phy.h>
>  
>  #include "ci.h"
>  #include "udc.h"
> @@ -211,6 +213,42 @@ static int hw_device_init(struct ci13xxx *ci, void __iomem *base)
>  	return 0;
>  }
>  
> +static void hw_phymode_configure(struct ci13xxx *ci)
> +{
> +	u32 portsc;
> +
> +	/*
> +	 * The lpm version has the corresponding bits in the devlc register.
> +	 * Currently not implemented.
> +	 */
> +	if (ci->hw_bank.lpm)
> +		return;
Why you don't implement it ?

If you don't implement it, I believe you should add a warning in order to catch
it when used with lpm devices.


Matthieu

  reply	other threads:[~2013-01-30 16:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 15:29 [PATCH] Add USB of helpers and use them in the chipidea driver Sascha Hauer
2013-01-30 15:29 ` [PATCH 1/6] USB: move bulk of otg/otg.c to phy/phy.c Sascha Hauer
2013-01-31  2:16   ` Peter Chen
2013-01-30 15:29 ` [PATCH 2/6] usb: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-01-31  2:30   ` Peter Chen
2013-01-31  8:05     ` Sascha Hauer
2013-01-31  6:14   ` kishon
2013-01-31  7:43     ` Sascha Hauer
2013-01-31  8:17       ` kishon
2013-01-30 15:29 ` [PATCH 3/6] usb: chipidea: ci13xxx-imx: create dynamic platformdata Sascha Hauer
2013-01-30 15:29 ` [PATCH 4/6] usb: chipidea: add PTW and PTS handling Sascha Hauer
2013-01-30 16:54   ` Matthieu CASTET [this message]
2013-01-30 19:33     ` Sascha Hauer
2013-01-31  9:15       ` Matthieu CASTET
2013-01-31  9:42         ` Sascha Hauer
2013-01-31  3:08   ` Peter Chen
2013-01-31  7:45     ` Sascha Hauer
2013-01-30 15:29 ` [PATCH 5/6] USB chipidea: introduce dual role mode pdata flags Sascha Hauer
2013-01-30 15:29 ` [PATCH 6/6] USB chipidea i.MX: introduce dr_mode property Sascha Hauer
  -- strict thread matches above, loose matches on Subject: below --
2013-01-31  9:01 [PATCH v2] Add USB of helpers and use them in the chipidea driver Sascha Hauer
2013-01-31  9:01 ` [PATCH 4/6] USB: chipidea: add PTW and PTS handling Sascha Hauer
2013-01-31  9:46   ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5109505E.7040204@parrot.com \
    --to=matthieu.castet@parrot.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.