Re: [PATCH 4/4] rbd: don't drop watch requests on completion

[Josh Durgin <josh.durgin@inktank.com>]

On 01/30/2013 12:38 PM, Alex Elder wrote:
> On 01/30/2013 01:43 PM, Josh Durgin wrote:
>> On 01/26/2013 12:41 PM, Alex Elder wrote:
>>> The new request code arranges to get a callback for every osd
>>> request we submit (this was not the case previously).
>>>
>>> We register a lingering object watch request for the header object
>>> for each mapped rbd image.
>>>
>>> If a connection problem occurs, the osd client will re-submit
>>> lingering requests.  And each time such a request is re-submitted,
>>> its callback function will get called again.
>>
>> I think this should be fixed in the osd_client - rbd should only get
>> the callback once, when the watch is first registered. Later we
>> could add a separate callback to handle re-registration if we need to.
>
> I agree.  Even so, I would like to maintain a reference
> to this lingering object request as is done in this patch.
> I think it makes sense even if we'll never get another
> callback.
>
> I would like to therefore address the multiple callback
> from the osd client as a separate issue.  If I update
> the comments here accordingly, and open a tracker issue
> for the other thing, would that be OK with you?

That's fine with me.