Re: [linux-lvm] lvm2 portability issues (GNU sed is assumed)

[John Spencer <maillist-lvm@barfooze.de>]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

On 01/30/2013 03:55 AM, Alasdair G Kergon wrote:
> On Tue, Jan 29, 2013 at 08:51:21PM +0100, John Spencer wrote:
>> may i ask kindly to reformulate that statement so that it works with
>> posix sed (as used in busybox 1.20.2) ?
>
> I'm perfectly happy using modern extensions to these tools:)
>
> If you want this to work with alternative versions, please send a tested
> patch for us to incorporate.  (Either modifications to the commands so
> it works with both or else alternative versions which configure chooses
> between.)

a couple of regex experts looked at it, and the reason it didnt work is 
simply a bug: the \ before d is wrong. apparently the author meant to 
escape the makefile variable that follows, but that is not necessary and 
so the backslash gets passed on.

find attached a patch that works correctly with gnu sed and busybox sed.

btw: apparently there are 2 other bugs in that sed statement:
| should become \| to work as intended by the author (gnu sed only), and 
[ \*] should become [ *].
but apparently this part of the regex isn't used anyway, so it might be 
the best to just remove it.
i left that part unfixed, as it is not crucial, so someone else might 
want to look at it.

thanks,
--JS

>
> Alasdair
>
>


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-make.tmpl.in-fix-buggy-sed-statement-that-worked-by-.patch --]
[-- Type: text/x-patch; name="0001-make.tmpl.in-fix-buggy-sed-statement-that-worked-by-.patch", Size: 0 bytes --]