From: Stephen Boyd <sboyd@codeaurora.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] gpg: Close stderr once finished with it in verify_signed_buffer()
Date: Thu, 31 Jan 2013 10:06:34 -0800 [thread overview]
Message-ID: <510AB2AA.4000400@codeaurora.org> (raw)
In-Reply-To: <20130131055053.GA11912@sigill.intra.peff.net>
On 01/30/13 21:50, Jeff King wrote:
>
> The strbuf_read above will read to EOF, so it should be equivalent (and
> IMHO slightly more readable) to do:
>
> diff --git a/gpg-interface.c b/gpg-interface.c
> index 0863c61..5f142f6 100644
> --- a/gpg-interface.c
> +++ b/gpg-interface.c
> @@ -130,8 +130,10 @@ int verify_signed_buffer(const char *payload, size_t payload_size,
> write_in_full(gpg.in, payload, payload_size);
> close(gpg.in);
>
> - if (gpg_output)
> + if (gpg_output) {
> strbuf_read(gpg_output, gpg.err, 0);
> + close(gpg.err);
> + }
> ret = finish_command(&gpg);
>
> unlink_or_warn(path);
>
> But that is a minor nit; either way, the patch looks good to me.
Looks better. I'll resend with this.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-01-31 18:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 2:01 [PATCH 0/3] GPG running out of pipes fixes Stephen Boyd
2013-01-31 2:01 ` [PATCH 1/3] gpg: Close stderr once finished with it in verify_signed_buffer() Stephen Boyd
2013-01-31 5:50 ` Jeff King
2013-01-31 18:06 ` Stephen Boyd [this message]
2013-01-31 18:18 ` [PATCHv2 " Stephen Boyd
2013-01-31 22:37 ` Jeff King
2013-01-31 2:01 ` [PATCH 2/3] run-command: Be more informative about what failed Stephen Boyd
2013-01-31 16:24 ` Junio C Hamano
2013-01-31 18:05 ` Stephen Boyd
2013-01-31 22:35 ` Jeff King
2013-01-31 23:57 ` Junio C Hamano
2013-01-31 2:01 ` [PATCH 3/3] gpg: Allow translation of more error messages Stephen Boyd
2013-01-31 18:20 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510AB2AA.4000400@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.