All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: fix bug on relocation address
Date: Thu, 31 Jan 2013 20:08:02 +0100	[thread overview]
Message-ID: <510AC112.2090409@myspectrum.nl> (raw)
In-Reply-To: <1359642542-18998-1-git-send-email-lroluk@gmail.com>

Hello Luca,

On 01/31/2013 03:29 PM, Luca Ellero wrote:
> If (N. SDRAM banks > 1) and they are not contiguous, don't relocate
> u-boot at (CONFIG_SYS_SDRAM_BASE + gd->ram_size), which is a bug.
> Instead use the end of 2nd bank (even if there are more than 2 banks)
>
> Signed-off-by: Luca Ellero <lroluk@gmail.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Heiko Schocher <hs@denx.de>
> ---
>
> On ARM architectures there is a bug getting top of SDRAM (where u-boot
> will be relocated). Top of SDRAM will always be:
>
> CONFIG_SYS_SDRAM_BASE + gd->ram_size
>
> anyway this can be wrong since SDRAM can be composed by more that one
> bank in not-contiguous address space.
I don't think this is a valid use case since the README says:

"The available memory is mapped to fixed addresses using the memory
controller. In this process, a contiguous block is formed for each
memory type (Flash, SDRAM, SRAM), even when it consists of several
physical memory banks."

Regards,
Jeroen

  reply	other threads:[~2013-01-31 19:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31 14:29 [U-Boot] [PATCH] arm: fix bug on relocation address Luca Ellero
2013-01-31 19:08 ` Jeroen Hofstee [this message]
2013-02-01  8:50   ` Luca Ellero
2013-02-01 10:07     ` Heiko Schocher
2013-02-01  9:49       ` Luca Ellero
2013-02-07  9:07         ` Luca Ellero
2013-02-01  8:17 ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510AC112.2090409@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.