All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Spencer <maillist-cryptsetup@barfooze.de>
To: dm-crypt@saout.de
Subject: [dm-crypt] [PATCH] fix portability issues encountered while building against musl libc
Date: Thu, 31 Jan 2013 20:15:15 +0100	[thread overview]
Message-ID: <510AC2C3.8010907@barfooze.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

2 header inclusions were missing, one for PATH_MAX (limits.h) and one 
for FD_ZERO, FD_SET, ... (sys/select.h)

on glibc, those headers are erroneusly (namespace pollution) pulled in 
through other headers, so the author didnt notice.

Signed-Off-By: John Spencer <maillist-cryptsetup@barfooze.de>

[-- Attachment #2: cryptsetup-devpath.patch --]
[-- Type: text/x-patch, Size: 328 bytes --]

--- cryptsetup-1.6.0.org/lib/utils_devpath.c	2013-01-30 19:45:47.142000003 +0000
+++ cryptsetup-1.6.0/lib/utils_devpath.c	2013-01-30 19:46:23.918000003 +0000
@@ -28,6 +28,7 @@
 #include <dirent.h>
 #include <fcntl.h>
 #include <errno.h>
+#include <limits.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include "utils_dm.h"

[-- Attachment #3: cryptsetup-random.patch --]
[-- Type: text/x-patch, Size: 301 bytes --]

--- cryptsetup-1.6.0.org/lib/random.c	2013-01-30 19:45:47.143000003 +0000
+++ cryptsetup-1.6.0/lib/random.c	2013-01-30 19:49:16.064000003 +0000
@@ -23,6 +23,7 @@
 #include <fcntl.h>
 #include <errno.h>
 #include <assert.h>
+#include <sys/select.h>
 
 #include "libcryptsetup.h"
 #include "internal.h"

             reply	other threads:[~2013-01-31 19:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31 19:15 John Spencer [this message]
2013-02-01  7:45 ` [dm-crypt] [PATCH] fix portability issues encountered while building against musl libc Milan Broz
2013-02-01 17:15   ` John Spencer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510AC2C3.8010907@barfooze.de \
    --to=maillist-cryptsetup@barfooze.de \
    --cc=dm-crypt@saout.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.