From: Tony Asleson <tasleson@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH V2 0/2] Add thin lv and thin pool creation support
Date: Thu, 31 Jan 2013 15:04:59 -0600 [thread overview]
Message-ID: <510ADC7B.3090903@redhat.com> (raw)
In-Reply-To: <1359642352-9688-1-git-send-email-mohan@in.ibm.com>
On 01/31/2013 08:25 AM, M. Mohan Kumar wrote:
> From: "M. Mohan Kumar" <mohan@in.ibm.com>
>
> Add thin lv and thin pool creation support to lvm2app.
>
> Changes from previous version:
> * Add support to specify data block size and low water mark thresold for
> newly created thin pool.
> * Added support for specifying lowwatermark parameter to thin pool
> creation in lvcreate command
OK, so the block size if specified as 0 results in a default value being
selected as before, which is what I believe we want. The default low
water mark was 0, which is what we believe disables event creation.
This doesn't appear to be a safe default behavior?
One option would be to change the type to a signed integer and change
the meaning from number of blocks free to percentage free and then treat
-1 as pick a sane default. Thus 0 would be no events and 30 would
indicate when 30% blocks free is remaining to generate an event. We
could also use an unsigned value and use 100 as please pick a sane
default as this value and values close to it really wouldn't make much
sense.
Once we have defined what the default values are, I can modify my python
bindings patch to use these default values.
Thanks,
Tony
next prev parent reply other threads:[~2013-01-31 21:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 14:25 [PATCH V2 0/2] Add thin lv and thin pool creation support M. Mohan Kumar
2013-01-31 14:25 ` [PATCH V2 1/2] lvm2app: Add thin and thin pool lv creation M. Mohan Kumar
2013-01-31 14:25 ` [PATCH V2 2/2] master - thin: Add lowwatermark parameter to pool creation M. Mohan Kumar
2013-01-31 21:04 ` Tony Asleson [this message]
2013-01-31 21:35 ` [PATCH V2 0/2] Add thin lv and thin pool creation support Zdenek Kabelac
2013-02-01 5:36 ` M. Mohan Kumar
2013-02-01 6:08 ` M. Mohan Kumar
2013-02-01 14:42 ` Tony Asleson
2013-02-01 17:27 ` M. Mohan Kumar
2013-02-01 17:28 ` M. Mohan Kumar
2013-02-04 23:24 ` Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510ADC7B.3090903@redhat.com \
--to=tasleson@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.