From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason77.wang@gmail.com (Hui Wang) Date: Fri, 1 Feb 2013 11:11:58 +0800 Subject: [PATCH v4 02/13] ARM: LPAE: use phys_addr_t in alloc_init_pud() In-Reply-To: <1359669512-31276-3-git-send-email-cyril@ti.com> References: <1359669512-31276-1-git-send-email-cyril@ti.com> <1359669512-31276-3-git-send-email-cyril@ti.com> Message-ID: <510B327E.3050502@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Cyril Chemparathy wrote: > From: Vitaly Andrianov > > This patch fixes the alloc_init_pud() function to use phys_addr_t instead of > unsigned long when passing in the phys argument. > > This is an extension to commit 97092e0c56830457af0639f6bd904537a150ea4a (ARM: > pgtable: use phys_addr_t for physical addresses), which applied similar changes > elsewhere in the ARM memory management code. > > Signed-off-by: Vitaly Andrianov > Signed-off-by: Cyril Chemparathy > Acked-by: Nicolas Pitre > Acked-by: Catalin Marinas > --- > arch/arm/mm/mmu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c > index 9f06102..ef43689 100644 > --- a/arch/arm/mm/mmu.c > +++ b/arch/arm/mm/mmu.c > @@ -612,7 +612,8 @@ static void __init alloc_init_section(pud_t *pud, unsigned long addr, > } > > static void __init alloc_init_pud(pgd_t *pgd, unsigned long addr, > - unsigned long end, unsigned long phys, const struct mem_type *type) > + unsigned long end, phys_addr_t phys, > + const struct mem_type *type) > The change is correct but seems useless so far. This function only be called from map_lowmem and devicemaps_init, from i know neither lowmem nor device io registers of existing platforms exceed 32bit address. regards, Hui. > { > pud_t *pud = pud_offset(pgd, addr); > unsigned long next; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229Ab3BADMY (ORCPT ); Thu, 31 Jan 2013 22:12:24 -0500 Received: from mail.windriver.com ([147.11.1.11]:47550 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752492Ab3BADMV (ORCPT ); Thu, 31 Jan 2013 22:12:21 -0500 Message-ID: <510B327E.3050502@gmail.com> Date: Fri, 1 Feb 2013 11:11:58 +0800 From: Hui Wang User-Agent: Thunderbird 2.0.0.24 (X11/20101027) MIME-Version: 1.0 To: Cyril Chemparathy CC: , , , , , , , , Vitaly Andrianov , , Subject: Re: [PATCH v4 02/13] ARM: LPAE: use phys_addr_t in alloc_init_pud() References: <1359669512-31276-1-git-send-email-cyril@ti.com> <1359669512-31276-3-git-send-email-cyril@ti.com> In-Reply-To: <1359669512-31276-3-git-send-email-cyril@ti.com> Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cyril Chemparathy wrote: > From: Vitaly Andrianov > > This patch fixes the alloc_init_pud() function to use phys_addr_t instead of > unsigned long when passing in the phys argument. > > This is an extension to commit 97092e0c56830457af0639f6bd904537a150ea4a (ARM: > pgtable: use phys_addr_t for physical addresses), which applied similar changes > elsewhere in the ARM memory management code. > > Signed-off-by: Vitaly Andrianov > Signed-off-by: Cyril Chemparathy > Acked-by: Nicolas Pitre > Acked-by: Catalin Marinas > --- > arch/arm/mm/mmu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c > index 9f06102..ef43689 100644 > --- a/arch/arm/mm/mmu.c > +++ b/arch/arm/mm/mmu.c > @@ -612,7 +612,8 @@ static void __init alloc_init_section(pud_t *pud, unsigned long addr, > } > > static void __init alloc_init_pud(pgd_t *pgd, unsigned long addr, > - unsigned long end, unsigned long phys, const struct mem_type *type) > + unsigned long end, phys_addr_t phys, > + const struct mem_type *type) > The change is correct but seems useless so far. This function only be called from map_lowmem and devicemaps_init, from i know neither lowmem nor device io registers of existing platforms exceed 32bit address. regards, Hui. > { > pud_t *pud = pud_offset(pgd, addr); > unsigned long next; >