From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH 3/4] Export blk_fill_rwbs() Date: Fri, 1 Feb 2013 11:57:30 +0800 Message-ID: <510B3D2A.3040007@huawei.com> References: <1358285142-10576-1-git-send-email-koverstreet@google.com> <1358285142-10576-3-git-send-email-koverstreet@google.com> <1359690521.5642.10.camel@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1359690521.5642.10.camel-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steven Rostedt Cc: Kent Overstreet , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Weisbecker , Ingo Molnar List-Id: linux-bcache@vger.kernel.org on 2013/2/1 11:48, Steven Rostedt wrote: > Li, > > Can you give an Ack or Nack for this. > I think this patch shouldn't go into upstream without bcache code. We don't export symbols for out of tree code. > Thanks, > > -- Steve > > > On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote: >> Exported so it can be used by bcache's tracepoints >> >> Signed-off-by: Kent Overstreet >> CC: Steven Rostedt >> CC: Frederic Weisbecker >> CC: Ingo Molnar >> --- >> kernel/trace/blktrace.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c >> index c0bd030..dbe1667 100644 >> --- a/kernel/trace/blktrace.c >> +++ b/kernel/trace/blktrace.c >> @@ -1806,6 +1806,7 @@ void blk_fill_rwbs(char *rwbs, u32 rw, int bytes) >> >> rwbs[i] = '\0'; >> } >> +EXPORT_SYMBOL_GPL(blk_fill_rwbs); >> >> #endif /* CONFIG_EVENT_TRACING */ >> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229Ab3BAD5w (ORCPT ); Thu, 31 Jan 2013 22:57:52 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:30661 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424Ab3BAD5v (ORCPT ); Thu, 31 Jan 2013 22:57:51 -0500 Message-ID: <510B3D2A.3040007@huawei.com> Date: Fri, 1 Feb 2013 11:57:30 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Steven Rostedt CC: Kent Overstreet , , , Frederic Weisbecker , Ingo Molnar Subject: Re: [PATCH 3/4] Export blk_fill_rwbs() References: <1358285142-10576-1-git-send-email-koverstreet@google.com> <1358285142-10576-3-git-send-email-koverstreet@google.com> <1359690521.5642.10.camel@gandalf.local.home> In-Reply-To: <1359690521.5642.10.camel@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.68.215] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on 2013/2/1 11:48, Steven Rostedt wrote: > Li, > > Can you give an Ack or Nack for this. > I think this patch shouldn't go into upstream without bcache code. We don't export symbols for out of tree code. > Thanks, > > -- Steve > > > On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote: >> Exported so it can be used by bcache's tracepoints >> >> Signed-off-by: Kent Overstreet >> CC: Steven Rostedt >> CC: Frederic Weisbecker >> CC: Ingo Molnar >> --- >> kernel/trace/blktrace.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c >> index c0bd030..dbe1667 100644 >> --- a/kernel/trace/blktrace.c >> +++ b/kernel/trace/blktrace.c >> @@ -1806,6 +1806,7 @@ void blk_fill_rwbs(char *rwbs, u32 rw, int bytes) >> >> rwbs[i] = '\0'; >> } >> +EXPORT_SYMBOL_GPL(blk_fill_rwbs); >> >> #endif /* CONFIG_EVENT_TRACING */ >> > > >