From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55929)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1Ff4-0002l3-ST
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 07:24:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1Ff3-00069w-M3
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 07:24:06 -0500
Received: from cantor2.suse.de ([195.135.220.15]:56317 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1Ff3-00069s-Fp
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 07:24:05 -0500
Message-ID: <510BB3E2.6090109@suse.de>
Date: Fri, 01 Feb 2013 13:24:02 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1359299779-25107-1-git-send-email-afaerber@suse.de>
	<510545C4.3060001@suse.de>
In-Reply-To: <510545C4.3060001@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.4] configure: Keep -Werror enabled
 for Release Candidates
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Am 27.01.2013 16:20, schrieb Andreas F=C3=A4rber:
> Am 27.01.2013 16:16, schrieb Andreas F=C3=A4rber:
>> The automatic drop of -Werror during the RC phases has in the past led
>> to warnings creeping into submaintainer trees.
>>
>> Last QEMU Summit it was concluded that -Werror should stay on and
>> enabled only as part of the release process.
>=20
> be disabled, obviously :)
>=20
>> To relieve our release manager, instead of always enabling -Werror or
>> doing some number magic, let's enable it depending on whether a .git/
>> directory exists in the source tree.
>>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>

Big PING for rc0!

Andreas

>> ---
>>  configure |    2 +-
>>  1 Datei ge=C3=A4ndert, 1 Zeile hinzugef=C3=BCgt(+), 1 Zeile entfernt(=
-)
>>
>> diff --git a/configure b/configure
>> index b7635e4..0657b1a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1180,7 +1180,7 @@ fi
>>  z_version=3D`cut -f3 -d. $source_path/VERSION`
>> =20
>>  if test -z "$werror" ; then
>> -    if test "$z_version" =3D "50" -a \
>> +    if test -d "$source_path/.git" -a \
>>          "$linux" =3D "yes" ; then
>>          werror=3D"yes"
>>      else
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg