From: Daniel Borkmann <dborkman@redhat.com>
To: Phil Sutter <phil.sutter@viprinet.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Johann Baudy <johann.baudy@gnu-log.net>
Subject: Re: [PATCH] packet: fix leakage of tx_ring memory
Date: Fri, 01 Feb 2013 17:48:04 +0100 [thread overview]
Message-ID: <510BF1C4.4050108@redhat.com> (raw)
In-Reply-To: <20130201162120.GA5543@philter.vipri.net>
On 02/01/2013 05:21 PM, Phil Sutter wrote:
> On Fri, Feb 01, 2013 at 05:05:08PM +0100, Daniel Borkmann wrote:
>> I think it would be easier / more readable to simply move the memset into
>> the two ifs than introducing an extra function for just doing that.
>
> Yes, this was just how my fix looked like initially, but I didn't like
> the resulting code duplication. Indeed, the extra function adds another
> point of code flow redirection. On the other hand, it implicitly points
> out that basically the same is done for both rings.
>
> In my point of view, both ways are equally acceptable. If you prefer the
> other one for mainline inclusion, just let me know and I submit an
> appropriate patch.
Yes, that'd be good, thanks.
next prev parent reply other threads:[~2013-02-01 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 13:57 [PATCH] packet: fix leakage of tx_ring memory Phil Sutter
2013-02-01 16:05 ` Daniel Borkmann
2013-02-01 16:21 ` Phil Sutter
2013-02-01 16:48 ` Daniel Borkmann [this message]
2013-02-01 17:21 ` [PATCH v2] " Phil Sutter
2013-02-01 17:25 ` Daniel Borkmann
2013-02-03 21:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510BF1C4.4050108@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=johann.baudy@gnu-log.net \
--cc=netdev@vger.kernel.org \
--cc=phil.sutter@viprinet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.