From mboxrd@z Thu Jan 1 00:00:00 1970 From: cyril@ti.com (Cyril Chemparathy) Date: Fri, 1 Feb 2013 12:56:54 -0500 Subject: [PATCH v4 02/13] ARM: LPAE: use phys_addr_t in alloc_init_pud() In-Reply-To: <510BFC84.2030902@gmail.com> References: <1359669512-31276-1-git-send-email-cyril@ti.com> <1359669512-31276-3-git-send-email-cyril@ti.com> <510B327E.3050502@gmail.com> <510BFC84.2030902@gmail.com> Message-ID: <510C01E6.2040108@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/01/2013 12:33 PM, Subash Patel wrote: > Hi Nicolas, > > On Thursday 31 January 2013 07:35 PM, Nicolas Pitre wrote: >> On Fri, 1 Feb 2013, Hui Wang wrote: >> >>> Cyril Chemparathy wrote: >>>> From: Vitaly Andrianov >>>> >>>> This patch fixes the alloc_init_pud() function to use phys_addr_t >>>> instead of >>>> unsigned long when passing in the phys argument. >>>> >>>> This is an extension to commit 97092e0c56830457af0639f6bd904537a150ea4a >>>> (ARM: >>>> pgtable: use phys_addr_t for physical addresses), which applied similar >>>> changes >>>> elsewhere in the ARM memory management code. >>>> >>>> Signed-off-by: Vitaly Andrianov >>>> Signed-off-by: Cyril Chemparathy >>>> Acked-by: Nicolas Pitre >>>> Acked-by: Catalin Marinas >>>> --- >>>> arch/arm/mm/mmu.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c >>>> index 9f06102..ef43689 100644 >>>> --- a/arch/arm/mm/mmu.c >>>> +++ b/arch/arm/mm/mmu.c >>>> @@ -612,7 +612,8 @@ static void __init alloc_init_section(pud_t *pud, >>>> unsigned long addr, >>>> } >>>> static void __init alloc_init_pud(pgd_t *pgd, unsigned long addr, >>>> - unsigned long end, unsigned long phys, const struct mem_type >>>> *type) >>>> + unsigned long end, phys_addr_t phys, >>>> + const struct mem_type *type) >>>> >>> The change is correct but seems useless so far. This function only be >>> called >>> from map_lowmem and devicemaps_init, from i know neither lowmem nor >>> device io >>> registers of existing platforms exceed 32bit address. >> >> It is not because you are not aware of any existing platforms with RAM >> or device IO above the 4GB mark that they don't exist. >> >> For example, some LPAE systems have all their RAM located above the 4G >> physical address mark. A simple (potentially non DMA capable) alias >> exists in the low 32-bit address space to allow the system to boot and >> switch to the real physical RAM addresses once the MMU is turned on. >> Some of that RAM is still qualified as "low mem" i.e. the portion of RAM >> that the kernel keeps permanently mapped in the 32-bit virtual space >> even if all of it is above the 4G mark in physical space. > > I think he is right. You cannot have low_mem and devices in 36-bit > areas. Atleast this is what I saw in one of the platforms on which I > tested these patches. I am not sure what you mean by hardware address > aliasing(as I have real RAM), but we need 32-bit areas to boot the CPU > and I have mapped them for the LOW_MEM. But, I have used 36-bit areas > for the HIGH_MEM. Since you said about aliasing DDR area in 32-bits, and > then switching to 36-bit RAM, does the dma of the devices still use > 32-bit aliased addresses? > > I haven't tested a configuration where LOW_MEM can have both 32-bit and > 36-bit DDR PA though. I think its not possible too. > On the KeyStone platform, memory is located at 08:0000:0000, i.e., outside the 32-bit addressable range. The hardware provides a limited aliased map of the very same memory at 8000:0000, but this alias is limited and intended only for boot time usage. We boot the system while running out of this 32-bit physical address range. We then switch over to the high physical address range fairly early in the kernel boot, by rewriting boot-time page tables and the TTBRs. Once this switch over has happened, lowmem is indeed outside the 32-bit physical address space. Thanks -- Cyril. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757357Ab3BAR5A (ORCPT ); Fri, 1 Feb 2013 12:57:00 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:54097 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757098Ab3BAR45 (ORCPT ); Fri, 1 Feb 2013 12:56:57 -0500 Message-ID: <510C01E6.2040108@ti.com> Date: Fri, 1 Feb 2013 12:56:54 -0500 From: Cyril Chemparathy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Subash Patel CC: Nicolas Pitre , Hui Wang , Russell King - ARM Linux , , Will Deacon , , , , Vitaly Andrianov , , Catalin Marinas , Subject: Re: [PATCH v4 02/13] ARM: LPAE: use phys_addr_t in alloc_init_pud() References: <1359669512-31276-1-git-send-email-cyril@ti.com> <1359669512-31276-3-git-send-email-cyril@ti.com> <510B327E.3050502@gmail.com> <510BFC84.2030902@gmail.com> In-Reply-To: <510BFC84.2030902@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2013 12:33 PM, Subash Patel wrote: > Hi Nicolas, > > On Thursday 31 January 2013 07:35 PM, Nicolas Pitre wrote: >> On Fri, 1 Feb 2013, Hui Wang wrote: >> >>> Cyril Chemparathy wrote: >>>> From: Vitaly Andrianov >>>> >>>> This patch fixes the alloc_init_pud() function to use phys_addr_t >>>> instead of >>>> unsigned long when passing in the phys argument. >>>> >>>> This is an extension to commit 97092e0c56830457af0639f6bd904537a150ea4a >>>> (ARM: >>>> pgtable: use phys_addr_t for physical addresses), which applied similar >>>> changes >>>> elsewhere in the ARM memory management code. >>>> >>>> Signed-off-by: Vitaly Andrianov >>>> Signed-off-by: Cyril Chemparathy >>>> Acked-by: Nicolas Pitre >>>> Acked-by: Catalin Marinas >>>> --- >>>> arch/arm/mm/mmu.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c >>>> index 9f06102..ef43689 100644 >>>> --- a/arch/arm/mm/mmu.c >>>> +++ b/arch/arm/mm/mmu.c >>>> @@ -612,7 +612,8 @@ static void __init alloc_init_section(pud_t *pud, >>>> unsigned long addr, >>>> } >>>> static void __init alloc_init_pud(pgd_t *pgd, unsigned long addr, >>>> - unsigned long end, unsigned long phys, const struct mem_type >>>> *type) >>>> + unsigned long end, phys_addr_t phys, >>>> + const struct mem_type *type) >>>> >>> The change is correct but seems useless so far. This function only be >>> called >>> from map_lowmem and devicemaps_init, from i know neither lowmem nor >>> device io >>> registers of existing platforms exceed 32bit address. >> >> It is not because you are not aware of any existing platforms with RAM >> or device IO above the 4GB mark that they don't exist. >> >> For example, some LPAE systems have all their RAM located above the 4G >> physical address mark. A simple (potentially non DMA capable) alias >> exists in the low 32-bit address space to allow the system to boot and >> switch to the real physical RAM addresses once the MMU is turned on. >> Some of that RAM is still qualified as "low mem" i.e. the portion of RAM >> that the kernel keeps permanently mapped in the 32-bit virtual space >> even if all of it is above the 4G mark in physical space. > > I think he is right. You cannot have low_mem and devices in 36-bit > areas. Atleast this is what I saw in one of the platforms on which I > tested these patches. I am not sure what you mean by hardware address > aliasing(as I have real RAM), but we need 32-bit areas to boot the CPU > and I have mapped them for the LOW_MEM. But, I have used 36-bit areas > for the HIGH_MEM. Since you said about aliasing DDR area in 32-bits, and > then switching to 36-bit RAM, does the dma of the devices still use > 32-bit aliased addresses? > > I haven't tested a configuration where LOW_MEM can have both 32-bit and > 36-bit DDR PA though. I think its not possible too. > On the KeyStone platform, memory is located at 08:0000:0000, i.e., outside the 32-bit addressable range. The hardware provides a limited aliased map of the very same memory at 8000:0000, but this alias is limited and intended only for boot time usage. We boot the system while running out of this 32-bit physical address range. We then switch over to the high physical address range fairly early in the kernel boot, by rewriting boot-time page tables and the TTBRs. Once this switch over has happened, lowmem is indeed outside the 32-bit physical address space. Thanks -- Cyril.