From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1LY3-0003qD-V9 for qemu-devel@nongnu.org; Fri, 01 Feb 2013 13:42:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1LJY-0002eX-DF for qemu-devel@nongnu.org; Fri, 01 Feb 2013 13:30:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1LJY-0002eT-5I for qemu-devel@nongnu.org; Fri, 01 Feb 2013 13:26:16 -0500 Message-ID: <510C0935.2020902@redhat.com> Date: Fri, 01 Feb 2013 19:28:05 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Seiji Aguchi Cc: "pbonzini@redhat.com" , "dle-develop@lists.sourceforge.net" , Satoru Moriya , "qemu-devel@nongnu.org" Hello Seiji-san, On 02/01/13 15:53, Seiji Aguchi wrote: > A logic calculating a time is copied from libvirt, src/util/virtime.c. > +static void error_print_timestamp(void) Are gmtime() + strftime() unsuitable for some reason? Also, since the timestamp is ultimately printed with millisecond resolution, clock_gettime(CLOCK_REALTIME) could be replaced with the more portable gettimeofday(). Thanks, Laszlo