From: Gabor Juhos <juhosg@openwrt.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] MIPS: start.S: unify and simplify reset vector handling
Date: Sat, 02 Feb 2013 01:44:44 +0100 [thread overview]
Message-ID: <510C617C.4010509@openwrt.org> (raw)
In-Reply-To: <CACUy__W4R36ixOhzjEcWYHiAFnbDYv-wwUAuUSgkjWGxb3+9Rw@mail.gmail.com>
2013.02.01. 23:48 keltez?ssel, Daniel Schwierzeck ?rta:
>>> + /* U-boot entry point */
>>> + b reset
>>> + nop
>>> +
>>> + .org 0x10
>>> #ifdef CONFIG_SYS_XWAY_EBU_BOOTCFG
>>
>> The .org should be within the ifdef. Although it does not change the generated
>> binary code, but logically it would be a more correct place. Sorry, I should
>> have mentioned that in the previous mail.
>>
>> -Gabor
>>
>>
>
> I think we should keep it outside. If we add qemu-malta, then we get
> another #if branch.
Ok, it does not really matter now. The .org can be moved into the ifdef later
when there will be a board which needs some other magic value at 0x14 for example.
> I also would like to move some register inits (watch, timer, status)
> to slightly reduce
> binary size.
Hm, do you want to initialize those registers between the reserved vectors?
-Gabor
prev parent reply other threads:[~2013-02-02 0:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 0:26 [U-Boot] [PATCH] MIPS: start.S: unify and simplify reset vector handling daniel.schwierzeck at gmail.com
2013-01-31 10:35 ` Gabor Juhos
2013-02-01 20:48 ` Daniel Schwierzeck
2013-02-01 20:55 ` [U-Boot] [PATCH v2] " daniel.schwierzeck at gmail.com
2013-02-01 22:17 ` Gabor Juhos
2013-02-01 22:48 ` Daniel Schwierzeck
2013-02-01 23:16 ` Langer Thomas
2013-02-02 0:44 ` Gabor Juhos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510C617C.4010509@openwrt.org \
--to=juhosg@openwrt.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.