From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 1/4] intel_idle: stop using driver_data for static flags Date: Sat, 02 Feb 2013 10:44:17 +0100 Message-ID: <510CDFF1.80408@linaro.org> References: <1359691896-23567-1-git-send-email-lenb@kernel.org> <9a38405338d7464c852c4524465f84f8a2ac22fb.1359691799.git.len.brown@intel.com> <510B8059.5040609@linaro.org> <510C0C22.4000801@kernel.org> <510C3EC5.3060709@linaro.org> <510C7708.4080707@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <510C7708.4080707-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org Errors-To: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org To: Len Brown Cc: Lists Linaro-dev , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pm@vger.kernel.org T24gMDIvMDIvMjAxMyAwMzoxNiBBTSwgTGVuIEJyb3duIHdyb3RlOgo+IAo+Pj4gaW50ZWxfaWRs ZSBhbHJlYWR5IHVzZXMgYSBkcml2ZXItc3BlY2lmaWMgZmxhZzoKPj4+Cj4+PiAjZGVmaW5lIENQ VUlETEVfRkxBR19UTEJfRkxVU0hFRCAgICAgICAgMHgxMDAwMAo+Pj4KPj4+IFRoaXMgcGF0Y2gg anVzdCB1c2VzIDQgbW9yZSBiaXRzIGFsb25nIHdpdGggdGhhdCBvbmUuCj4+Cj4+IE9rLiBJbiB0 aGlzIGNhc2UgaXQgd291bGQgbWFrZSBzZW5zZSB0byBtb3ZlIHRoaXMgZmxhZyBvdXQgb2YgdGhl Cj4+IGdlbmVyaWMgY29yZSBjb2RlIHRvIHRoZSBpbnRlbF9pZGxlLmMgZmlsZSA/Cj4gCj4gVGhp cyBmbGFnIGlzIGFscmVhZHkgbG9jYWwgdG8gaW50ZWxfaWRsZS5jLgo+IElmIGFub3RoZXIgYXJj aGl0ZWN0dXJlIGZpbmRzIGl0IHVzZWZ1bCwKPiB0aGVuIHllcywgaXQgd291bGQgbWFrZSBzZW5z ZSB0byBtb3ZlIGl0IHRvIHRoZSBzaGFyZWQgaGVhZGVyLgoKT2gsIHJpZ2h0LiBTb3JyeSBJIHB1 enpsZWQgbXlzZWxmIHdpdGggdGhlIG5hbWUuIEkgd2FzIGNvbnZpbmNlZCBpdCB3YXMKaW4gdGhl IHNoYXJlZCBoZWFkZXIuCgo+PiBhbmQgbW92ZSB0aGUgW2RlYy9lbl1jb2RpbmcKPj4gbWFjcm8g ZmxhZ3NfMl9NV0FJVF9FQVggYW5kIE1XQUlUX0VBWF8yX2ZsYWdzICh3aXRoIGEgbW9yZSBhcHBy b3ByaWF0ZQo+PiBuYW1lIGZvciBhIGdlbmVyaWMgY29kZSkgdG8gdGhlIGNwdWlkbGUuaCBmaWxl ID8KPiAKPiBJIHRoaW5rIHRoYXQgYSBkcml2ZXIncyBwcml2YXRlIGZsYWcgZGVmaW5pdGlvbnMK PiBzaG91bGQgcmVtYWluIGxvY2FsIHRvIHRoZSBkcml2ZXIuICBJdCBtYWtlcyBubyBzZW5zZQo+ IHRvIHBvbGx1dGUgdGhlIG5hbWUgc3BhY2Ugb2Ygb3RoZXIgZHJpdmVycyBmb3Igc3R1ZmYKPiB0 aGF0IGRvZXNuJ3QgbWVhbiBhbnl0aGluZyB0byB0aGVtLiAgTVdBSVQgaXMgcHJldHR5Cj4gc3Bl Y2lmaWMgdG8geDg2IC0tIGFuZCByZS1uYW1pbmcgaXQgdG8gc29tZXRoaW5nICdnZW5lcmljJwo+ IGlzbid0IGdvaW5nIHRvIG1ha2UgdGhlIGNvZGUgZWFzaWVyIHRvIHJlYWQuCgpPaywgbGV0IG1l IHJlcGhyYXNlIGl0IGJlY2F1c2UgSSB0aGluayBob3cgaXQgd2FzIHByZXNlbnRlZCB3YXMgbm90 IGNsZWFyLgoKQXMgd2Ugd2FudCB0byB1c2UgdGhlIGhhbGYgb2YgdGhlIHN0YXRlIGZsYWdzIGZv ciBwcml2YXRlIHB1cnBvc2UsIEkKc3VnZ2VzdGVkIHRvIGFkZCB0aGUgZW5jb2RpbmcvZGVjb2Rp bmcgZnVuY3Rpb24gaW4gdGhlIHNoYXJlZCBoZWFkZXIgZmlsZS4KClRoZSBtd2FpdCBlYXggZmxh Z3MgYXJlIG5vdCBlbmNvZGVkIGFuZCB0aGUgQ1BVSURMRV9GTEFHX1RMQl9GTFVTSEVEIGlzCmVu Y29kZWQuCgpJIHN1Z2dlc3RlZCB0byB1bmlmeSBib3RoIGFuZCB0byB1c2UgYW4gZW5jb2Rpbmcg ZnVuY3Rpb24gZnJvbSB0aGUKc2hhcmVkIGhlYWRlciBmaWxlLgoKI2RlZmluZSBDUFVJRExFX1BS SVZBVEVfRkxBR1MoX2ZsYWdzXykgXAoJKChfZmxhZ3NfKSA8PCAxNikgJiBDUFVJRExFX0RSSVZF Ul9GTEFHU19NQVNLCgpGb3IgZXhhbXBsZToKCiNkZWZpbmUgRkxBR19UTEJfRkxVU0hFRCBDUFVJ RExFX1BSSVZBVEVfRkxBR1MoMHgxKQojZGVmaW5lIEZMQUdfTVdBSVRfQzEgICAgQ1BVSURMRV9Q UklWQVRFX0ZMQUdTKDB4MCkKI2RlZmluZSBGTEFHX01XQUlUX0MyICAgIENQVUlETEVfUFJJVkFU RV9GTEFHUygweDEwKQojZGVmaW5lIEZMQUdfTVdBSVRfQzMgICAgQ1BVSURMRV9QUklWQVRFX0ZM QUdTKDB4MjApCiNkZWZpbmUgRkxBR19NV0FJVF9DNCAgICBDUFVJRExFX1BSSVZBVEVfRkxBR1Mo MHgzMCkKI2RlZmluZSBGTEFHX01XQUlUX0M1ICAgIENQVUlETEVfUFJJVkFURV9GTEFHUygweDQw KQojZGVmaW5lIEZMQUdfTVdBSVRfQzYgICAgQ1BVSURMRV9QUklWQVRFX0ZMQUdTKDB4NTIpCgpB bmQgdGhlbjoKCi4uLgoKLmZsYWdzID0gRkxBR19UTEJfRkxVU0hFRCB8IEZMQUdfTVdBSVRfQzIg fCBDUFVJRExFX0ZMQUdfVElNRV9WQUxJRAoKLi4uCgpCdXQgaW4gdGhlIGlkbGUgZnVuY3Rpb24s IHlvdSBuZWVkIHRvIHJldHJpZXZlIHRoZSAndmFsdWUnIG9mIHRoZSBFQVgKbm90IGEgZmxhZywg c28gdGhlcmUgaXMgdGhlIG5lZWQgZm9yIGFuIGV4dHJhIG1hY3JvIGNvbnZlcnNpb24gYW5kIG1h c2sKdGhlIFRMQiBmbGFnLgoKV2VsbCwgdGhpcyBpcyBhIGRldGFpbCwgc28gZmVlbCBmcmVlIHRv IGlnbm9yZSB0aGlzIHN1Z2dlc3Rpb24gOikKClRoYW5rcwogIC0tIERhbmllbAoKLS0gCiA8aHR0 cDovL3d3dy5saW5hcm8ub3JnLz4gTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUg Zm9yIEFSTSBTb0NzCgpGb2xsb3cgTGluYXJvOiAgPGh0dHA6Ly93d3cuZmFjZWJvb2suY29tL3Bh Z2VzL0xpbmFybz4gRmFjZWJvb2sgfAo8aHR0cDovL3R3aXR0ZXIuY29tLyMhL2xpbmFyb29yZz4g VHdpdHRlciB8CjxodHRwOi8vd3d3LmxpbmFyby5vcmcvbGluYXJvLWJsb2cvPiBCbG9nCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGluYXJvLWRldiBt YWlsaW5nIGxpc3QKbGluYXJvLWRldkBsaXN0cy5saW5hcm8ub3JnCmh0dHA6Ly9saXN0cy5saW5h cm8ub3JnL21haWxtYW4vbGlzdGluZm8vbGluYXJvLWRldgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755060Ab3BBJo0 (ORCPT ); Sat, 2 Feb 2013 04:44:26 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:58388 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753665Ab3BBJoX (ORCPT ); Sat, 2 Feb 2013 04:44:23 -0500 Message-ID: <510CDFF1.80408@linaro.org> Date: Sat, 02 Feb 2013 10:44:17 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Len Brown CC: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Lists Linaro-dev Subject: Re: [PATCH 1/4] intel_idle: stop using driver_data for static flags References: <1359691896-23567-1-git-send-email-lenb@kernel.org> <9a38405338d7464c852c4524465f84f8a2ac22fb.1359691799.git.len.brown@intel.com> <510B8059.5040609@linaro.org> <510C0C22.4000801@kernel.org> <510C3EC5.3060709@linaro.org> <510C7708.4080707@kernel.org> In-Reply-To: <510C7708.4080707@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2013 03:16 AM, Len Brown wrote: > >>> intel_idle already uses a driver-specific flag: >>> >>> #define CPUIDLE_FLAG_TLB_FLUSHED 0x10000 >>> >>> This patch just uses 4 more bits along with that one. >> >> Ok. In this case it would make sense to move this flag out of the >> generic core code to the intel_idle.c file ? > > This flag is already local to intel_idle.c. > If another architecture finds it useful, > then yes, it would make sense to move it to the shared header. Oh, right. Sorry I puzzled myself with the name. I was convinced it was in the shared header. >> and move the [dec/en]coding >> macro flags_2_MWAIT_EAX and MWAIT_EAX_2_flags (with a more appropriate >> name for a generic code) to the cpuidle.h file ? > > I think that a driver's private flag definitions > should remain local to the driver. It makes no sense > to pollute the name space of other drivers for stuff > that doesn't mean anything to them. MWAIT is pretty > specific to x86 -- and re-naming it to something 'generic' > isn't going to make the code easier to read. Ok, let me rephrase it because I think how it was presented was not clear. As we want to use the half of the state flags for private purpose, I suggested to add the encoding/decoding function in the shared header file. The mwait eax flags are not encoded and the CPUIDLE_FLAG_TLB_FLUSHED is encoded. I suggested to unify both and to use an encoding function from the shared header file. #define CPUIDLE_PRIVATE_FLAGS(_flags_) \ ((_flags_) << 16) & CPUIDLE_DRIVER_FLAGS_MASK For example: #define FLAG_TLB_FLUSHED CPUIDLE_PRIVATE_FLAGS(0x1) #define FLAG_MWAIT_C1 CPUIDLE_PRIVATE_FLAGS(0x0) #define FLAG_MWAIT_C2 CPUIDLE_PRIVATE_FLAGS(0x10) #define FLAG_MWAIT_C3 CPUIDLE_PRIVATE_FLAGS(0x20) #define FLAG_MWAIT_C4 CPUIDLE_PRIVATE_FLAGS(0x30) #define FLAG_MWAIT_C5 CPUIDLE_PRIVATE_FLAGS(0x40) #define FLAG_MWAIT_C6 CPUIDLE_PRIVATE_FLAGS(0x52) And then: ... .flags = FLAG_TLB_FLUSHED | FLAG_MWAIT_C2 | CPUIDLE_FLAG_TIME_VALID ... But in the idle function, you need to retrieve the 'value' of the EAX not a flag, so there is the need for an extra macro conversion and mask the TLB flag. Well, this is a detail, so feel free to ignore this suggestion :) Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog