From: Ben Peddell <klightspeed@killerwolves.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] target: OOPS in target_fabric_port_link on v3.7.4 and v3.4.27
Date: Sun, 03 Feb 2013 18:31:59 +1000 [thread overview]
Message-ID: <510E207F.1@killerwolves.net> (raw)
There is an OOPS in target_fabric_port_link due to a use before
initialization error.
commit 0ff8754981261a80f4b77db2536dfea92c2d4539 (target: Add link_magic
for fabric allow_link destination target_items) as merged in the
linux-3.7.y and linux-3.4.y branches relies on one of the changes that
occurred in commit 0fd97ccf45be26fb01b3a412f1f6c6b5044b2f16 (Simplify
the code a lot by killing the superflous struct se_subsystem_dev).
Without that change, dev is dereferenced before it is initialized.
Commit 0fd97ccf45be26fb01b3a412f1f6c6b5044b2f16 looks too invasive,
which I would guess would be why it wasn't merged in.
One option would be to move the dev->dev_link_magic test to after dev is
initialized, as presented the patches I will be following up with.
An alternative that will resolve this OOPS is to revert commit
fdf9d862969f1be18814273b03fb9497ec2dbdae (target: Add link_magic for
fabric allow_link destination target_items) on branch linux-3.7.y, and
revert commit 92a7389317838f3338466df0c0e3d23ad33cb1f4 (target: Add
link_magic for fabric allow_link destination target_items) on branch
linux-3.4.y
next reply other threads:[~2013-02-03 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 8:31 Ben Peddell [this message]
2013-02-03 8:33 ` [PATCH 1/2] 3.4.y target: Move dev->dev_link_magic check Ben Peddell
2013-02-03 8:34 ` [PATCH 2/2] 3.7.y " Ben Peddell
2013-02-03 9:42 ` [PATCH 0/2] target: OOPS in target_fabric_port_link on v3.7.4 and v3.4.27 Ben Peddell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510E207F.1@killerwolves.net \
--to=klightspeed@killerwolves.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.