All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kjell Braden <afflux-7cISTWZqsW8RLla1DLYS2Q@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cifs: ensure that cifs_get_root() only traverses directories
Date: Sun, 03 Feb 2013 17:49:38 +0100	[thread overview]
Message-ID: <510E9522.8040508@pentabarf.de> (raw)
In-Reply-To: <1359749461-13458-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On 2013-02-01 21:11, Jeff Layton wrote:
> When walking down the path on the server, it's possible to hit a
> symlink. The path walking code assumes that the caller will handle that
> situation properly, but cifs_get_root() isn't set up for it. This patch
> prevents the oops by simply returning an error.
>
> A better solution would be to try and chase the symlinks here, but that's
> fairly complicated to handle.


Hi,

  let me add that mounting paths below symlinks worked with the old path 
walking before commit fec11dd9a0109fe52fd631e5c510778d6cbff6cc.

  While it's not a big deal to work around this once the oops is fixed, 
it would be great if the regression could be fixed.

-- 
Kjell

  parent reply	other threads:[~2013-02-03 16:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 20:11 [PATCH] cifs: ensure that cifs_get_root() only traverses directories Jeff Layton
     [not found] ` <1359749461-13458-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-02-02  5:33   ` Steve French
2013-02-03 16:49   ` Kjell Braden [this message]
     [not found]     ` <510E9522.8040508-7cISTWZqsW8RLla1DLYS2Q@public.gmane.org>
2013-02-03 16:54       ` Kjell Braden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510E9522.8040508@pentabarf.de \
    --to=afflux-7cistwzqsw8rlla1dlys2q@public.gmane.org \
    --cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.