From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm: fix compile failure by including Date: Sun, 03 Feb 2013 22:58:29 +0100 Message-ID: <510EDD85.60909@canonical.com> References: <201302012045.r11KjctX014737@farm-0002.internal.tilera.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTP id A6BC6E5C3B for ; Sun, 3 Feb 2013 13:58:42 -0800 (PST) In-Reply-To: <201302012045.r11KjctX014737@farm-0002.internal.tilera.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Metcalf Cc: Thomas Hellstrom , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jerome Glisse , Ben Skeggs , Alex Deucher , Dave Airlie List-Id: dri-devel@lists.freedesktop.org Op 01-02-13 19:44, Chris Metcalf schreef: > On tile architecture (with "make allyesconfig") including > is required to call swiotlb_nr_tbl(). I'll take your word for the need, since I lack the hardware to verify the failure. :-) Applying your patch doesn't seem to break compilation on x86 though, which is good enough for me. Acked-by: Maarten Lankhorst > Signed-off-by: Chris Metcalf > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > drivers/gpu/drm/radeon/radeon_ttm.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > index 69d7b1d..1699a90 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -28,6 +28,7 @@ > */ > > #include > +#include > > #include > #include > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c > index 1d8ff2f..93f760e 100644 > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include > #include "radeon_reg.h" > #include "radeon.h" > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753874Ab3BCV6i (ORCPT ); Sun, 3 Feb 2013 16:58:38 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:36174 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670Ab3BCV6f (ORCPT ); Sun, 3 Feb 2013 16:58:35 -0500 Message-ID: <510EDD85.60909@canonical.com> Date: Sun, 03 Feb 2013 22:58:29 +0100 From: Maarten Lankhorst User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Chris Metcalf CC: linux-kernel@vger.kernel.org, David Airlie , Ben Skeggs , Dave Airlie , Thomas Hellstrom , Alex Deucher , Jerome Glisse , Christian Konig , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: fix compile failure by including References: <201302012045.r11KjctX014737@farm-0002.internal.tilera.com> In-Reply-To: <201302012045.r11KjctX014737@farm-0002.internal.tilera.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 01-02-13 19:44, Chris Metcalf schreef: > On tile architecture (with "make allyesconfig") including > is required to call swiotlb_nr_tbl(). I'll take your word for the need, since I lack the hardware to verify the failure. :-) Applying your patch doesn't seem to break compilation on x86 though, which is good enough for me. Acked-by: Maarten Lankhorst > Signed-off-by: Chris Metcalf > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > drivers/gpu/drm/radeon/radeon_ttm.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > index 69d7b1d..1699a90 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -28,6 +28,7 @@ > */ > > #include > +#include > > #include > #include > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c > index 1d8ff2f..93f760e 100644 > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include > #include "radeon_reg.h" > #include "radeon.h" >