From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Peres Subject: Re: [PATCH 1/3] drm/nouveau/therm: turn on a fan only when crossing threshold in positive direction Date: Mon, 04 Feb 2013 13:22:30 +0100 Message-ID: <510FA806.3000701@labri.fr> References: <1359922077-3347-1-git-send-email-marcin.slusarz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1359922077-3347-1-git-send-email-marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Marcin Slusarz Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org On 03/02/2013 21:07, Marcin Slusarz wrote: > + the same for shutdown threshold - seems impossible, but shutdown can fail. > > Signed-off-by: Marcin Slusarz Looks good. Please add my signed-off-by Signed-off-by: Martin Peres > --- > drivers/gpu/drm/nouveau/core/subdev/therm/temp.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/core/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/core/subdev/therm/temp.c > index bf9b3ce..8f27b44 100644 > --- a/drivers/gpu/drm/nouveau/core/subdev/therm/temp.c > +++ b/drivers/gpu/drm/nouveau/core/subdev/therm/temp.c > @@ -105,7 +105,7 @@ void nouveau_therm_sensor_event(struct nouveau_therm *therm, > return; > > if (dir == NOUVEAU_THERM_THRS_FALLING) > - nv_info(therm, "temperature (%u C) went bellow the '%s' threshold\n", > + nv_info(therm, "temperature (%u C) went below the '%s' threshold\n", > temperature, thresolds[thrs]); > else > nv_info(therm, "temperature (%u C) hit the '%s' threshold\n", > @@ -114,8 +114,10 @@ void nouveau_therm_sensor_event(struct nouveau_therm *therm, > active = (dir == NOUVEAU_THERM_THRS_RISING); > switch (thrs) { > case NOUVEAU_THERM_THRS_FANBOOST: > - nouveau_therm_fan_set(therm, true, 100); > - nouveau_therm_mode(therm, NOUVEAU_THERM_CTRL_AUTO); > + if (active) { > + nouveau_therm_fan_set(therm, true, 100); > + nouveau_therm_mode(therm, NOUVEAU_THERM_CTRL_AUTO); > + } > break; > case NOUVEAU_THERM_THRS_DOWNCLOCK: > if (priv->emergency.downclock) > @@ -126,7 +128,8 @@ void nouveau_therm_sensor_event(struct nouveau_therm *therm, > priv->emergency.pause(therm, active); > break; > case NOUVEAU_THERM_THRS_SHUTDOWN: > - orderly_poweroff(true); > + if (active) > + orderly_poweroff(true); > break; > case NOUVEAU_THERM_THRS_NR: > break;