Re: [PATCH V2 0/2] spi/bcm63xx: fix multi transfer messages

[Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>]

On 02/03/2013 03:15 PM, Jonas Gorski wrote:
> The bcm63xx SPI controller does not support keeping CS up after doing a
> transfer. Since this is problematic for most typical use cases, this
> patchset introduces a workaround by combining small enough messages
> to one transfer, rejecting anything that can't be fulfilled with the
> hardware.
>
> Patch one properly rejects anything impossible to transfer with these
> limitations.
> Patch two introduces logic for combining transfers to one to be able to
> use it for typical use cases (register accesses and flash access).
>
> Build and run tested on a BCM6368 with a SPI controlled switch attached
> requiring write-then-read with CS asserted.
>
> Changes V1 -> V2:
>   * split into two patches
>   * fixed return type of bcm63xx_txrx_bufs()
>   * slightly reworked bcm63xx_txrx_bufs, obsoleting one local variable
>   * added a bit more comments in the code
>   * added error messages indicated why transfers were rejected

Looks good, thanks!

Acked-by: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
--
Florian

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan