From: "Andreas Färber" <afaerber@suse.de>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-trivial@nongnu.org, kwolf@redhat.com,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message
Date: Mon, 04 Feb 2013 14:48:28 +0100 [thread overview]
Message-ID: <510FBC2C.1000500@suse.de> (raw)
In-Reply-To: <510FB89E.1080504@adacore.com>
Am 04.02.2013 14:33, schrieb Fabien Chouteau:
> On 02/04/2013 01:24 PM, Markus Armbruster wrote:
>>
>> Good error reporting is hard. Knowledge about the error and its context
>> gets lost as you move up the call chain. Knowledge about how to report
>> errors gets lost as you move down.
>>
>
> You're right, and in my opinion, no error reporting is the worst case.
The best solution would be to pass an Error **errp argument and use
error_setg() on it, as done for visitors and QOM. Then the caller can
decide whether to pass NULL and the callee can report detailed errors.
Invasive change obviously and thus not suitable for 1.4.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-02-04 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 17:13 [Qemu-trivial] [PATCH] get_tmp_filename: add explicit error message Fabien Chouteau
2013-02-04 8:39 ` Stefan Hajnoczi
2013-02-04 10:34 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2013-02-04 11:27 ` Fabien Chouteau
2013-02-04 12:24 ` Markus Armbruster
2013-02-04 13:33 ` Fabien Chouteau
2013-02-04 13:48 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510FBC2C.1000500@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=chouteau@adacore.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.