From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?EUC-KR?B?sei9wr/s?= Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D Date: Tue, 05 Feb 2013 16:56:03 +0900 Message-ID: <5110BB13.8080803@samsung.com> References: <1359107722-9974-1-git-send-email-sachin.kamat@linaro.org> <1359107722-9974-2-git-send-email-sachin.kamat@linaro.org> <510987B5.6090509@gmail.com> <050101cdff52$86df3a70$949daf50$%dae@samsung.com> <510B02AB.4080908@gmail.com> <0b7501ce0011$3df65180$b9e2f480$@samsung.com> <00fd01ce001b$5215a3f0$f640ebd0$%dae@samsung.com> <510B9EC8.6020102@samsung.com> <014401ce006f$c7dd1dd0$57975970$%dae@samsung.com> <014501ce0072$9eca1a80$dc5e4f80$%dae@samsung.com> Reply-To: sw0312.kim@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=EUC-KR Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: Sender: linux-media-owner@vger.kernel.org To: Inki Dae Cc: Sachin Kamat , Kukjin Kim , "patches@linaro.org" , "devicetree-discuss@lists.ozlabs.org" , "dri-devel@lists.freedesktop.org" , Sylwester Nawrocki , Sylwester Nawrocki , "linux-media@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hi Inki, On 2013=B3=E2 02=BF=F9 05=C0=CF 12:03, Inki Dae wrote: > 2013/2/4 Sachin Kamat : >> On 1 February 2013 18:28, Inki Dae wrote: >>> >>> >>> >>> >>> 2013. 2. 1. =BF=C0=C8=C4 8:52 Inki Dae =C0=DB= =BC=BA: >>> >>>> >>>> >>>>> -----Original Message----- >>>>> From: linux-media-owner@vger.kernel.org [mailto:linux-media- >>>>> owner@vger.kernel.org] On Behalf Of Sachin Kamat >>>>> Sent: Friday, February 01, 2013 8:40 PM >>>>> To: Inki Dae >>>>> Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- >>>>> media@vger.kernel.org; dri-devel@lists.freedesktop.org; devicetre= e- >>>>> discuss@lists.ozlabs.org; patches@linaro.org >>>>> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discov= ery >>>>> support for G2D >>>>> >>>>> On 1 February 2013 17:02, Inki Dae wrote: >>>>>> >>>>>> How about using like below? >>>>>> Compatible =3D ""samsung,exynos4x12-fimg-2d" /* for Exyno= s4212, >>>>>> Exynos4412 */ >>>>>> It looks odd to use "samsung,exynos4212-fimg-2d" saying that thi= s ip is >>>>> for >>>>>> exynos4212 and exynos4412. >>>>> >>>>> AFAIK, compatible strings are not supposed to have any wildcard >>>> characters. >>>>> Compatible string should suggest the first SoC that contained thi= s IP. >>>>> Hence IMO 4212 is OK. >>>>> >>> >>> Oops, one more thing. AFAIK Exynos4210 also has fimg-2d ip. In this= case, we should use "samsung,exynos4210-fimg-2d" as comparible string = and add it to exynos4210.dtsi? >> >> Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same >> comptible string will be used for this one too. >> >>> And please check if exynos4212 and 4412 SoCs have same fimg-2d ip. = If it's different, we might need to add ip version property or compatib= le string to each dtsi file to identify the ip version. >> >> AFAIK, they both have the same IP (v4.1). >> >=20 > Ok, let's use the below, >=20 > For exynos4210 SoC, > compatible =3D "samsung,exynos4210-g2d" >=20 > For exynos4x12 SoCs, > compatible =3D "samsung,exynos4212-g2d" >=20 > For exynos5250, 5410 (In case of Exynos5440, I'm not sure that the So= C > has same ip) > compatible =3D "samsung,exynos5250-g2d" >=20 > To other guys, > The device tree is used by not only v4l2 side but also drm side so we > should reach an arrangement. So please give me ack if you agree to my > opinion. Otherwise please, give me your opinions. This seems good to me. Best Regards, - Seung-Woo Kim >=20 > Thanks, > Inki Dae >=20 >=20 >>> >>> Sorry but give me your opinions. >>> >>> Thanks, >>> Inki Dae >>> >>> >>>> >>>> Got it. Please post it again. >>>> >>>>> >>>>> -- >>>>> With warm regards, >>>>> Sachin >>>>> -- >>>>> To unsubscribe from this list: send the line "unsubscribe linux-m= edia" in >>>>> the body of a message to majordomo@vger.kernel.org >>>>> More majordomo info at http://vger.kernel.org/majordomo-info.htm= l >>>> >>>> _______________________________________________ >>>> dri-devel mailing list >>>> dri-devel@lists.freedesktop.org >>>> http://lists.freedesktop.org/mailman/listinfo/dri-devel >> >> >> >> -- >> With warm regards, >> Sachin > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >=20 --=20 Seung-Woo Kim Samsung Software R&D Center --