From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon Subject: Re: [PATCH v2 4/6] ARM: dts: omap5: add dwc3 omap dt data Date: Tue, 5 Feb 2013 14:16:36 +0530 Message-ID: <5110C6EC.6050606@ti.com> References: <1359112312-6918-1-git-send-email-kishon@ti.com> <1359112312-6918-5-git-send-email-kishon@ti.com> <510432BF.80808@mvista.com> <5110C2E6.30504@ti.com> <20130205083828.GE32118@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130205083828.GE32118-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: balbi-l0cyMroinI0@public.gmane.org Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, Sergei Shtylyov , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org, s-guiriec-l0cyMroinI0@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-omap@vger.kernel.org Hi, On Tuesday 05 February 2013 02:08 PM, Felipe Balbi wrote: > On Tue, Feb 05, 2013 at 01:59:26PM +0530, kishon wrote: >> On Sunday 27 January 2013 01:17 AM, Sergei Shtylyov wrote: >>> Hello. >>> >>> On 25-01-2013 15:11, Kishon Vijay Abraham I wrote: >>> >>>> Add dwc3 omap glue data to the omap5 dt data file. The information about >>>> the dt node added here is available @ >>>> Documentation/devicetree/bindings/usb/omap-usb.txt >>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> arch/arm/boot/dts/omap5.dtsi | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>> >>>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi >>>> index 5f59bf2..1703a72 100644 >>>> --- a/arch/arm/boot/dts/omap5.dtsi >>>> +++ b/arch/arm/boot/dts/omap5.dtsi >>>> @@ -513,6 +513,17 @@ >>>> ti,type = <2>; >>>> }; >>>> >>>> + omap_dwc3@4a020000 { >>>> + compatible = "ti,dwc3"; >>>> + ti,hwmods = "usb_otg_ss"; >>>> + reg = <0x4a020000 0x1ff>; >>> >>> Shoudn't the "reg" length be 0x200 here? It's length, not limit. >> >> I think 0x1ff is correct. I got the data from hwmod data. > > hwmod is utterly wrong. Looking at TRM, it says the size here is 64KiB > (0x10000), so is the size for dwc3 itself. Please don't blindly trust > hwmod, make sure you read data from TRM ;-) hmm..ok. But it has only 17 registers :-D Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (kishon) Date: Tue, 5 Feb 2013 14:16:36 +0530 Subject: [PATCH v2 4/6] ARM: dts: omap5: add dwc3 omap dt data In-Reply-To: <20130205083828.GE32118@arwen.pp.htv.fi> References: <1359112312-6918-1-git-send-email-kishon@ti.com> <1359112312-6918-5-git-send-email-kishon@ti.com> <510432BF.80808@mvista.com> <5110C2E6.30504@ti.com> <20130205083828.GE32118@arwen.pp.htv.fi> Message-ID: <5110C6EC.6050606@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tuesday 05 February 2013 02:08 PM, Felipe Balbi wrote: > On Tue, Feb 05, 2013 at 01:59:26PM +0530, kishon wrote: >> On Sunday 27 January 2013 01:17 AM, Sergei Shtylyov wrote: >>> Hello. >>> >>> On 25-01-2013 15:11, Kishon Vijay Abraham I wrote: >>> >>>> Add dwc3 omap glue data to the omap5 dt data file. The information about >>>> the dt node added here is available @ >>>> Documentation/devicetree/bindings/usb/omap-usb.txt >>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> arch/arm/boot/dts/omap5.dtsi | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>> >>>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi >>>> index 5f59bf2..1703a72 100644 >>>> --- a/arch/arm/boot/dts/omap5.dtsi >>>> +++ b/arch/arm/boot/dts/omap5.dtsi >>>> @@ -513,6 +513,17 @@ >>>> ti,type = <2>; >>>> }; >>>> >>>> + omap_dwc3 at 4a020000 { >>>> + compatible = "ti,dwc3"; >>>> + ti,hwmods = "usb_otg_ss"; >>>> + reg = <0x4a020000 0x1ff>; >>> >>> Shoudn't the "reg" length be 0x200 here? It's length, not limit. >> >> I think 0x1ff is correct. I got the data from hwmod data. > > hwmod is utterly wrong. Looking at TRM, it says the size here is 64KiB > (0x10000), so is the size for dwc3 itself. Please don't blindly trust > hwmod, make sure you read data from TRM ;-) hmm..ok. But it has only 17 registers :-D Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755140Ab3BEIrC (ORCPT ); Tue, 5 Feb 2013 03:47:02 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:35487 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064Ab3BEIq6 (ORCPT ); Tue, 5 Feb 2013 03:46:58 -0500 Message-ID: <5110C6EC.6050606@ti.com> Date: Tue, 5 Feb 2013 14:16:36 +0530 From: kishon User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: CC: Sergei Shtylyov , , , , , , , , , Subject: Re: [PATCH v2 4/6] ARM: dts: omap5: add dwc3 omap dt data References: <1359112312-6918-1-git-send-email-kishon@ti.com> <1359112312-6918-5-git-send-email-kishon@ti.com> <510432BF.80808@mvista.com> <5110C2E6.30504@ti.com> <20130205083828.GE32118@arwen.pp.htv.fi> In-Reply-To: <20130205083828.GE32118@arwen.pp.htv.fi> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 05 February 2013 02:08 PM, Felipe Balbi wrote: > On Tue, Feb 05, 2013 at 01:59:26PM +0530, kishon wrote: >> On Sunday 27 January 2013 01:17 AM, Sergei Shtylyov wrote: >>> Hello. >>> >>> On 25-01-2013 15:11, Kishon Vijay Abraham I wrote: >>> >>>> Add dwc3 omap glue data to the omap5 dt data file. The information about >>>> the dt node added here is available @ >>>> Documentation/devicetree/bindings/usb/omap-usb.txt >>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> arch/arm/boot/dts/omap5.dtsi | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>> >>>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi >>>> index 5f59bf2..1703a72 100644 >>>> --- a/arch/arm/boot/dts/omap5.dtsi >>>> +++ b/arch/arm/boot/dts/omap5.dtsi >>>> @@ -513,6 +513,17 @@ >>>> ti,type = <2>; >>>> }; >>>> >>>> + omap_dwc3@4a020000 { >>>> + compatible = "ti,dwc3"; >>>> + ti,hwmods = "usb_otg_ss"; >>>> + reg = <0x4a020000 0x1ff>; >>> >>> Shoudn't the "reg" length be 0x200 here? It's length, not limit. >> >> I think 0x1ff is correct. I got the data from hwmod data. > > hwmod is utterly wrong. Looking at TRM, it says the size here is 64KiB > (0x10000), so is the size for dwc3 itself. Please don't blindly trust > hwmod, make sure you read data from TRM ;-) hmm..ok. But it has only 17 registers :-D Thanks Kishon