Re: [PATCH v2 02/11] xen: return proper type for guest access functions

[Jan Beulich <jbeulich@suse.com>]

On 23.03.2026 17:29, Oleksii Kurochko wrote:
> --- a/xen/include/xen/fdt-domain-build.h
> +++ b/xen/include/xen/fdt-domain-build.h
> @@ -44,10 +44,10 @@ static inline int get_allocation_size(paddr_t size)
>      return get_order_from_bytes(size + 1) - 1;
>  }
>  
> -typedef unsigned long (*copy_to_guest_phys_cb)(struct domain *d,
> -                                               paddr_t gpa,
> -                                               void *buf,
> -                                               unsigned int len);
> +typedef unsigned int (*copy_to_guest_phys_cb)(struct domain *d,
> +                                              paddr_t gpa,
> +                                              void *buf,
> +                                              unsigned int len);

When making this change, did you look at the use sites of this type? If
so, did it not occur to you that initrd-s can be pretty much arbitrarily
large, i.e. in particular be larger than 4Gb? IOW I think there's a
truncation bug to be fixed in Arm / DT code.

Jan